Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix nunjucks use in document builder by calling mapArgs in non-extension context #2091

Closed
twschiller opened this issue Dec 9, 2021 · 0 comments · Fixed by #2093
Closed
Assignees
Labels
bug Something isn't working enhancement New feature or request runtime

Comments

@twschiller
Copy link
Contributor

twschiller commented Dec 9, 2021

Context

  • Document builder's list element calls mapArgs for !defer content: #1976 Document Builder. Lists #2077
  • Our CSP for the extension page (correctly) blocks it because nunjucks uses eval under the hood

Implementation Sketch

  • Expose a method to run mapArgs in the contentScript API (similar to runEffectPipeline)
  • Call that method instead of calling mapArgs directly

Related

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working enhancement New feature or request runtime
Development

Successfully merging a pull request may close this issue.

1 participant