-
Notifications
You must be signed in to change notification settings - Fork 23
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
#1976 Document Builder. Lists #2077
Conversation
Testing notes We probably don't need to support this out of the gate, but I noticed manually providing a list errors out: I wrote a jq brick with a hard-code list in the filter:
I'm getting some issue running the panel. I can help look into it with a debugger tomorrow I also hit an issue where the builder would crash when I went to another extension in the devtools sidebar and then switched back to the new document I was working on. I need to find reproduction steps for that, though |
<GridLoader /> | ||
) : ( | ||
<> | ||
{rootDefinitions.map(({ documentElement, elementContext }, i) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Somehow I'm getting an Cannot read properties of undefined (reading 'map')
error here
I think it happens when there's an error calculating the asyncState?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I updated this to display the error when the factory of useAsyncState fails
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@BALEHOK Looking good. I will create a separate issue for running mapArgs in a different context
One improvement I'd make is to make |
Relates to #1976
Edit page:
Side panel: