Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to build on 32 bit arch (i386) #6

Closed
nunotexbsd opened this issue Dec 2, 2022 · 2 comments · Fixed by #10
Closed

Fails to build on 32 bit arch (i386) #6

nunotexbsd opened this issue Dec 2, 2022 · 2 comments · Fixed by #10

Comments

@nunotexbsd
Copy link

FreeBSD 12.3 i386 / go 1.19.3

Building https://github.com/go-git/go-git:
pjbgf:sha1cd:v0.2.0:pjbgf_sha1cd/vendor/github.com/pjbgf/sha1cd

# github.com/pjbgf/sha1cd/cgo
vendor/github.com/pjbgf/sha1cd/cgo/sha1_nix.go:19:31: cannot use (_Ctype_ulong)(len(p)) (value of type _Ctype_ulong) as type _Ctype_uint in variable declaration

Are i386 or other 32 bit archs supported?

Thanks
freebsd-git pushed a commit to freebsd/freebsd-ports that referenced this issue Dec 2, 2022
@nunotexbsd
devel/go-git: Update to 5.5.0
61a7a96 
 - broken on i386, issue: pjbgf/sha1cd#6
 - switch back to "gomod-vendor" method because GO_MODULES is failing,
   issue: go-git/go-git#626

ChangeLog:	https://github.com/go-git/go-git/releases/tag/v5.5.0
@martinlindhe martinlindhe mentioned this issue Dec 3, 2022
Closed
yann-soubeyrand added a commit to yann-soubeyrand/sha1cd that referenced this issue Dec 3, 2022
@yann-soubeyrand
fix: correct type cast error
52128f4 
Closes pjbgf#6
Closes pjbgf#8
@yann-soubeyrand yann-soubeyrand mentioned this issue Dec 3, 2022
Merged
@yann-soubeyrand
Copy link
Contributor

Hello @nunotexbsd,
Can you try my PR to see if it fixes your issue?
You can use the following directive in your go.mod file:
replace github.com/pjbgf/sha1cd v0.2.2 => github.com/yann-soubeyrand/sha1cd fix-type-cast.

yann-soubeyrand added a commit to yann-soubeyrand/sha1cd that referenced this issue Dec 3, 2022
@yann-soubeyrand
fix: correct type cast error
0771a15 
Closes pjbgf#6
Closes pjbgf#8
pjbgf pushed a commit to yann-soubeyrand/sha1cd that referenced this issue Dec 3, 2022
@yann-soubeyrand @pjbgf
fix: correct type cast error
14fb474 
Closes pjbgf#6
Closes pjbgf#8
@pjbgf pjbgf closed this as completed in #10 Dec 3, 2022
@pjbgf
Copy link
Owner

pjbgf commented Dec 3, 2022

github.com/pjbgf/sha1cd v0.2.3 has now being released with the fix.

osokin pushed a commit to osokin/freebsd-ports that referenced this issue Jun 18, 2023
@nunotexbsd @osokin
devel/go-git: Update to 5.5.0
b01e7f2 
 - broken on i386, issue: pjbgf/sha1cd#6
 - switch back to "gomod-vendor" method because GO_MODULES is failing,
   issue: go-git/go-git#626

ChangeLog:	https://github.com/go-git/go-git/releases/tag/v5.5.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expand multi-arch support by fixing type cast yann-soubeyrand/sha1cd
3 participants
@pjbgf @yann-soubeyrand @nunotexbsd