Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fails to build on x86_64-pc-msys #8

Closed
martinlindhe opened this issue Dec 3, 2022 · 4 comments · Fixed by #10
Closed

Fails to build on x86_64-pc-msys #8

martinlindhe opened this issue Dec 3, 2022 · 4 comments · Fixed by #10

Comments

@martinlindhe
Copy link

I see a similar error to #6, but different arch and different types so i opened a separate issue.

on gcc x86_64-pc-msys 11.3

# github.com/pjbgf/sha1cd/cgo
..\..\..\go\pkg\mod\github.com\pjbgf\sha1cd@v0.2.2\cgo\sha1_windows.go:19:31: cannot use (_Ctype_ulonglong)(len(p)) (value of type _Ctype_ulonglong) as type _Ctype_ulong in variable declaration
yann-soubeyrand added a commit to yann-soubeyrand/sha1cd that referenced this issue Dec 3, 2022
@yann-soubeyrand
fix: correct type cast error
52128f4 
Closes pjbgf#6
Closes pjbgf#8
@yann-soubeyrand yann-soubeyrand mentioned this issue Dec 3, 2022
Merged
@yann-soubeyrand
Copy link
Contributor

Hello @martinlindhe,
Can you try my PR to see if it fixes your issue?
You can use the following directive in your go.mod file:
replace github.com/pjbgf/sha1cd v0.2.2 => github.com/yann-soubeyrand/sha1cd fix-type-cast.

yann-soubeyrand added a commit to yann-soubeyrand/sha1cd that referenced this issue Dec 3, 2022
@yann-soubeyrand
fix: correct type cast error
0771a15 
Closes pjbgf#6
Closes pjbgf#8
@martinlindhe
Copy link
Author

martinlindhe commented Dec 3, 2022 •
edited
Loading

Confirmed working with the fix-type-cast branch and mingw-w64-x86_64-gcc

@pjbgf pjbgf closed this as completed in #10 Dec 3, 2022
@pjbgf pjbgf closed this as completed in 14fb474 Dec 3, 2022
@pjbgf
Copy link
Owner

pjbgf commented Dec 3, 2022

github.com/pjbgf/sha1cd v0.2.3 has now being released with the fix.

@martinlindhe
Copy link
Author

@pjbgf Thank you so much!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Expand multi-arch support by fixing type cast yann-soubeyrand/sha1cd
3 participants
@martinlindhe @pjbgf @yann-soubeyrand