Skip to content

Commit

Permalink
issue #75: add tag OHC
Browse files Browse the repository at this point in the history
  • Loading branch information
pkiraly committed Dec 18, 2020
1 parent 53651c5 commit ed3d53a
Show file tree
Hide file tree
Showing 4 changed files with 72 additions and 2 deletions.
2 changes: 1 addition & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -8,5 +8,5 @@
690, 692, 852$a (code list), 859, 909, 916, 917, 945, 950, 954, 955, 957, 959, 960,
961, 962, 963, 964, 966, 968, 970, 975, 976, 979, 980, 985, 990, 992, 996, 997,
A02, AQN, BGT, BUF, CFI, CNF, DGM, DRT, EST, EXP, FFP, FIN, LAS, LCS, LDO, LEO, LET,
MIS, MNI, MPX, NEG, NID, OBJ
MIS, MNI, MPX, NEG, NID, OBJ, OHC

Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import de.gwdg.metadataqa.marc.definition.Cardinality;
import de.gwdg.metadataqa.marc.definition.DataFieldDefinition;
import de.gwdg.metadataqa.marc.definition.Indicator;
import de.gwdg.metadataqa.marc.definition.general.validator.RegexValidator;

/**
* Original Holding Count
*/
public class TagOHC extends DataFieldDefinition {

private static TagOHC uniqueInstance;

private TagOHC() {
initialize();
postCreation();
}

public static TagOHC getInstance() {
if (uniqueInstance == null)
uniqueInstance = new TagOHC();
return uniqueInstance;
}

private void initialize() {

tag = "OHC";
label = "Original Holding Count";
mqTag = "OriginalHoldingCount";
cardinality = Cardinality.Nonrepeatable;
// descriptionUrl = "https://www.loc.gov/marc/bibliographic/bd037.html";
// setCompilanceLevels("O");

ind1 = new Indicator();

ind2 = new Indicator();

setSubfieldsWithCardinality(
"a", "Original holding count", "NR"
);

getSubfield("a")
.setValidator(new RegexValidator("^\\d+$"))
.setMqTag("originalHoldingCount");
}
}
Original file line number Diff line number Diff line change
@@ -0,0 +1,23 @@
package de.gwdg.metadataqa.marc.definition.tags.bltags;

import org.junit.Test;

public class TagOHCTest extends BLTagTest {

public TagOHCTest() {
super(TagOHC.getInstance());
}

@Test
public void testValidFields() {
validField("a", "1");
validField("a", "11");
}

@Test
public void testInvalidFields() {
invalidField("1", "a", "1");
invalidField("a", "1.");
invalidField("b", "1");
}
}
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ public void testListTag() {
List<Class<? extends DataFieldDefinition>> tags = MarcTagLister.listTags();
assertNotNull(tags);
assertNotEquals(0, tags.size());
assertEquals(388, tags.size());
assertEquals(389, tags.size());
assertEquals("Tag010", tags.get(0).getSimpleName());
Map<String, Integer> versionCounter = new HashMap<>();
Map<MarcVersion, Integer> versionCounter2 = new HashMap<>();
Expand Down

0 comments on commit ed3d53a

Please sign in to comment.