Trying to fix flaky test

pkirilin · Jul 16, 2024 · dcb8332 · dcb8332
1 parent e07991f
commit dcb8332
Show file tree

Hide file tree

Showing 2 changed files with 9 additions and 0 deletions.
diff --git a/...rontend/src/features/product/addEdit/ui/ProductInputDialog/ProductInputDialog.fixture.tsx b/...rontend/src/features/product/addEdit/ui/ProductInputDialog/ProductInputDialog.fixture.tsx
@@ -110,6 +110,10 @@ export const whenProductSaved = async (user: UserEvent): Promise<void> => {
 export const expectCategory = (name: string): SelectOption =>
   expect.objectContaining<Partial<SelectOption>>({ name });
 
+export const thenProductFormIsVisible = async (): Promise<void> => {
+  expect(await screen.findByRole('dialog', { name: /product/i })).toBeVisible();
+};
+
 export const thenFormValueContains = async (
   onSubmitMock: Mock,
   product: productModel.FormValues,

diff --git a/src/frontend/src/features/product/addEdit/ui/ProductInputDialog/ProductInputDialog.test.tsx b/src/frontend/src/features/product/addEdit/ui/ProductInputDialog/ProductInputDialog.test.tsx
@@ -12,6 +12,7 @@ import {
   thenDefaultQuantityIsInvalid,
   thenDialogShouldBeHidden,
   thenFormValueContains,
+  thenProductFormIsVisible,
   thenProductNameHasValue,
   thenProductNameIsInvalid,
   thenProductNameIsValid,
@@ -39,6 +40,8 @@ test('I can add new product', async () => {
   );
 
   await whenDialogOpened(user);
+  await thenProductFormIsVisible();
+
   await whenProductNameChanged(user, 'Potato');
   await whenCaloriesCostChanged(user, '150');
   await whenDefaultQuantityChanged(user, '120');
@@ -71,6 +74,8 @@ test('I can edit product', async () => {
   );
 
   await whenDialogOpened(user);
+  await thenProductFormIsVisible();
+
   await whenProductNameChanged(user, 'Potato edited');
   await whenCaloriesCostChanged(user, '140');
   await whenDefaultQuantityChanged(user, '110');