guids collection to movie and GuidTag PlexObject #562
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi, you still can't search by guids, but you can print a Item.guids Regards. |
blacktwin
reviewed
Nov 4, 2020
| @@ -589,6 +612,10 @@ class Genre(MediaTag): | |||
| TAG = 'Genre' | |||
| FILTER = 'genre' | |||
|
|
|||
| @utils.registerPlexObject | |||
There was a problem hiding this comment.
Needs an additional line spacing around this class.
|
The test environment would need at least one Movie Library to have the new Plex Movie agent enabled in order to add any testing related to this PR. |
|
looking forward to this to get merged. it's a dependency of such or: Taxel/PlexTraktSync#86 |
This was referenced Dec 6, 2020
7 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested implementation for Movie guids collection and GuidTag PlexObject in reference to new Plex movie agent, which is still in beta.
MediaTag's id expects type int, so I figured a specific version might be better. Might be worth implementing parsing of the expected id's (tmdb or imdb), but for now this fits to the existing tag collection model