Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for the new Plex Movie agent #628

Merged
merged 7 commits into from
Jan 25, 2021

Conversation

JonnyWong16
Copy link
Collaborator

@JonnyWong16 JonnyWong16 commented Dec 16, 2020

Description

This PR is a continuation of #562 since it seems to have been abandoned.

  • Adds the external guids to the Movie object
  • Updates the bootstrap test server to the Plex Movie agent for the movies library.
  • Updates the relevant tests for the new Plex Movie agent.

Closes #562

Important!

Do not merge yet! The new Plex Movie agent does not work for an unclaimed Plex server (FYI, neither does the Plex Music agent). It seems like the "new" Plex agents require a Plex account and a claimed server, otherwise they will not return any metadata and library items cannot be matched.

The new tests for the Plex Movie agent do pass for a claimed Plex server.

Type of change

Please delete options that are not relevant.

  • New feature (non-breaking change which adds functionality)
  • This change requires a documentation update

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added or updated the docstring for new or existing methods
  • I have added tests when applicable

@Hellowlol
Copy link
Collaborator

@JonnyWong16 Can you check if the failing tests is related to the PR?

@JonnyWong16
Copy link
Collaborator Author

The failing test is because of the important note in my description above. The Plex Movie agent does not return any metadata for unclaimed servers.

Either this is a bug that needs to be fixed by Plex, or they tell us that this is intended and we revert back to the legacy Plex Movie agent.

@JonnyWong16
Copy link
Collaborator Author

If we want to add new movie Guids without the tests, then merge #562 and cherry-pick d102ef3, 1f2abdd, f313df3.

@Hellowlol
Copy link
Collaborator

I suggest we add a new library that uses the new agent and the same time keep the old one.

@darthShadow darthShadow mentioned this pull request Dec 31, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants