Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(connection_pool.cr): only yield cnx if it exists and not closed #25

Merged
merged 6 commits into from
Sep 3, 2021
Merged

fix(connection_pool.cr): only yield cnx if it exists and not closed #25

merged 6 commits into from
Sep 3, 2021

Conversation

dukenguyenxyz
Copy link
Contributor

@dukenguyenxyz dukenguyenxyz self-assigned this Sep 3, 2021
@dukenguyenxyz dukenguyenxyz merged commit b0bab5c into master Sep 3, 2021
@stakach stakach deleted the fix/refresh-db-2 branch September 3, 2021 11:07
@dukenguyenxyz
Copy link
Contributor Author

the recovery testing steps:

  • launch an app that uses clear and connects to a database
  • test the api is working
  • restart the database container
  • test the api is working

current result:

  • connection error is raised once after container restarts
  • afterwards connection is re-established

@dukenguyenxyz dukenguyenxyz mentioned this pull request Sep 7, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stakach stakach Awaiting requested review from stakach

Assignees

@dukenguyenxyz dukenguyenxyz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dukenguyenxyz @caspiano