Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf(connection_pool.cr): retry on using_connection #26

Merged
merged 3 commits into from
Sep 15, 2021
Merged

perf(connection_pool.cr): retry on using_connection #26

merged 3 commits into from
Sep 15, 2021

Conversation

dukenguyenxyz
Copy link
Contributor

Recovery testing outline:

  • launch an app that uses clear and connects to a database
  • test the api is working
  • restart the database container
  • test the api is working

Result:

@dukenguyenxyz dukenguyenxyz self-assigned this Sep 7, 2021
stakach
stakach approved these changes Sep 7, 2021
View reviewed changes
Copy link
Contributor

@stakach stakach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dukenguyenxyz dukenguyenxyz merged commit e8bad23 into master Sep 15, 2021
@dukenguyenxyz dukenguyenxyz deleted the feat/retry_2 branch September 15, 2021 23:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stakach stakach stakach approved these changes

@caspiano caspiano Awaiting requested review from caspiano

Assignees

@dukenguyenxyz dukenguyenxyz

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Application does not recover following loss of connectivity with DB
2 participants
@dukenguyenxyz @stakach