proxy: pick up a random port and bind to the correct port #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR changes the address to bind locally. Instead of binding to an hardcoded port, we now let the OS pick up a random port for us. In order to make this work, we had to introduce a new method to the `sql-proxy` repo (planetscale/sql-proxy#52). Both `pscale shell` and `pscale connect` now automatically binds to a random port. closes planetscale/surfaces#111
nickvanw
approved these changes
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes the address to bind locally. Instead of binding to a hardcoded port, we now let the OS pick up a random port for us. We had to introduce a new method to the
sql-proxyrepo (planetscale/sql-proxy#52) to make this work.Both
pscale shellandpscale connectnow automatically bind to a random port.closes https://github.com/planetscale/project-big-bang/issues/111