This repository has been archived by the owner on Oct 23, 2024. It is now read-only.
proxy: add LocalAddr() method #52
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fatih
force-pushed
the
fatih/add-local-addr
branch
from
ff61e7b to
fce701a
Compare
This method exposes the underlying listener's local address. It will be useful to get the address if the listener binds to an address in the form "127.0.0.1:0", which picks up a random port. /xref planetscale/surfaces#111
fatih
force-pushed
the
fatih/add-local-addr
branch
from
fce701a to
c82065c
Compare
vmg
approved these changes
Mar 2, 2021
fatih
added a commit
to planetscale/cli
that referenced
this pull request
Mar 2, 2021
This PR changes the address to bind locally. Instead of binding to an hardcoded port, we now let the OS pick up a random port for us. In order to make this work, we had to introduce a new method to the `sql-proxy` repo (planetscale/sql-proxy#52). Both `pscale shell` and `pscale connect` now automatically binds to a random port. closes planetscale/surfaces#111
fatih
added a commit
to planetscale/cli
that referenced
this pull request
Mar 2, 2021
This PR changes the address to bind locally. Instead of binding to an hardcoded port, we now let the OS pick up a random port for us. In order to make this work, we had to introduce a new method to the `sql-proxy` repo (planetscale/sql-proxy#52). Both `pscale shell` and `pscale connect` now automatically binds to a random port. closes planetscale/surfaces#111
asbiaidw5
added a commit
to asbiaidw5/cli
that referenced
this pull request
Aug 6, 2024
This PR changes the address to bind locally. Instead of binding to an hardcoded port, we now let the OS pick up a random port for us. In order to make this work, we had to introduce a new method to the `sql-proxy` repo (planetscale/sql-proxy#52). Both `pscale shell` and `pscale connect` now automatically binds to a random port. closes planetscale/surfaces#111
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method exposes the underlying listener's local address. It will be useful to get the address if the listener binds to an address in the form "127.0.0.1:0", which picks up a random port.
/xref https://github.com/planetscale/project-big-bang/issues/111