Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Check for arrow functions in utils.getAssertContextNameForTest #214

Merged
merged 2 commits into from
Nov 3, 2021
Merged

Fix: Check for arrow functions in utils.getAssertContextNameForTest #214

merged 2 commits into from
Nov 3, 2021

Conversation

edg2s
Copy link
Contributor

@edg2s edg2s commented Nov 2, 2021 •
edited
Loading

Fixes #213

bmish
bmish approved these changes Nov 2, 2021
View reviewed changes
Copy link
Collaborator

@bmish bmish left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI, it looks like getAssertContextNameForTest is used in many more rules.

@coveralls
Copy link

coveralls commented Nov 2, 2021 •
edited
Loading

Coverage Status

Coverage remained the same at 100.0% when pulling 6c750c4 on edg2s:no-loose-assertion-arrow into 34968fe on platinumazure:master.

@edg2s
Copy link
Contributor Author

edg2s commented Nov 2, 2021

FYI, it looks like getAssertContextNameForTest is used in many more rules.

Good point.

@edg2s edg2s changed the title Fix: Check for arrow functions in no-loose-assertions & no-assert-ok Fix: Check for arrow functions in utils.getAssertContextNameForTest Nov 2, 2021
platinumazure
platinumazure approved these changes Nov 3, 2021
View reviewed changes
Copy link
Owner

@platinumazure platinumazure left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for contributing!

@platinumazure platinumazure merged commit ad5f79f into platinumazure:master Nov 3, 2021
@edg2s edg2s deleted the no-loose-assertion-arrow branch November 3, 2021 16:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@platinumazure platinumazure platinumazure approved these changes

@bmish bmish bmish approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

no-loose-assertions and many other rules don't work in arrow functions
4 participants
@edg2s @coveralls @platinumazure @bmish