Expose utils for expression LSP #117
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adierkens
force-pushed
the
expression-lsp
branch
from
c1a9a33 to
801fbaf
Compare
|
/canary |
|
/canary |
Codecov ReportBase: 79.07% // Head: 79.10% // Increases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## main #117 +/- ##
==========================================
+ Coverage 79.07% 79.10% +0.03%
==========================================
Files 132 132
Lines 4655 4662 +7
Branches 1164 1167 +3
==========================================
+ Hits 3681 3688 +7
Misses 688 688
Partials 286 286
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
KetanReddy
reviewed
Jan 23, 2023
|
|
||
| // Expressions can be separated by semicolons, commas, or just inferred without any | ||
| // separators | ||
| if (chIndex === SEMCOL_CODE || chIndex === COMMA_CODE) { |
There was a problem hiding this comment.
Would there be any worth to having the kind of characters that are ignored be configurable?
There was a problem hiding this comment.
That may make it pretty difficult to define a proper bnf grammar for expressions. But that might be worth considering as a future change
This was referenced Jan 25, 2023
This was referenced Oct 26, 2023
Merged
This was referenced Nov 6, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Release Notes
parseExpressionfrom the expression parserstrictflag toparseExpressionthat will (when disabled) attach any parsing errors to the top-level node instead of throwing