Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse and Forward Symbols in the View Parser #130

Merged
merged 1 commit into from
Jan 24, 2023

Conversation

KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Jan 23, 2023

If an Asset has a property that is keyed by a Symbol, that property is not retained in the final view output. While this can't really happen with content loaded from a JSON file, for content that is dynamically generated there may be symbols present.

Version

Published prerelease version: 0.4.0-next.4

Changelog

Release Notes

Expose utils for expression LSP (#117)

  • Expose parseExpression from the expression parser
  • Adds a strict flag to parseExpression that will (when disabled) attach any parsing errors to the top-level node instead of throwing

Deps/bump dependencies (#111)

Dependency upgrades

Sync Latest Player Code (#109)

Syncs to latest version and bumps tapable-ts to latest version.


🚀 Enhancement

🐛 Bug Fix

Authors: 7

@KetanReddy KetanReddy added the patch Increment the patch version when merged label Jan 23, 2023
@KetanReddy KetanReddy self-assigned this Jan 23, 2023
@KetanReddy KetanReddy requested a review from adierkens as a code owner January 23, 2023 18:57
@codecov
Copy link

codecov bot commented Jan 23, 2023

Codecov Report

Base: 79.07% // Head: 79.08% // Increases project coverage by +0.00% 🎉

Coverage data is based on head (cc91930) compared to base (99cb3dd).
Patch coverage: 100.00% of modified lines in pull request are covered.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #130   +/-   ##
=======================================
  Coverage   79.07%   79.08%           
=======================================
  Files         132      132           
  Lines        4655     4656    +1     
  Branches     1164     1164           
=======================================
+ Hits         3681     3682    +1     
  Misses        688      688           
  Partials      286      286           
Impacted Files Coverage Δ
core/player/src/view/parser/index.ts 79.26% <100.00%> (+0.25%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants