iOS: Canary release support + SPM automated releases #434
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/canary |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #434 +/- ##
=======================================
Coverage ? 91.71%
=======================================
Files ? 338
Lines ? 26798
Branches ? 1938
=======================================
Hits ? 24579
Misses ? 2205
Partials ? 14 ☔ View full report in Codecov by Sentry. |
|
/canary |
|
/canary |
|
/canary |
|
/canary |
|
/canary |
|
/canary |
|
/canary |
hborawski
changed the title
|
/canary |
|
/canary |
nancywu1
reviewed
Jul 19, 2024
| @@ -26,8 +26,7 @@ done | |||
| # Rebuild to stamp the release podspec | |||
| bazel build --config=release //:PlayerUI_Podspec //:PlayerUI_Pod | |||
|
|
|||
| # VScode extension publishing | |||
| bazel run --config=release //language/vscode-player-syntax:vscode-plugin.publish | |||
There was a problem hiding this comment.
should this VScode extension publishing be removed?
There was a problem hiding this comment.
yeah this target is gone now, so it was just throwing errors
functionality was moved to the tools repo
|
/canary |
nancywu1
approved these changes
Jul 22, 2024
This was referenced Jul 22, 2024
Merged
This was referenced Jul 29, 2024
Merged
Merged
Merged
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #407
Change Type (required)
Indicate the type of change your pull request is:
patchminormajorDoes your PR have any documentation updates?
📦 Published PR as canary version:
0.7.5--canary.434.15236Try this version out locally by upgrading relevant packages to 0.7.5--canary.434.15236