Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

JS Package Cleanup #442

Merged
merged 3 commits into from
Jul 22, 2024
Merged

JS Package Cleanup #442

merged 3 commits into from
Jul 22, 2024

Conversation

KetanReddy
Copy link
Member

@KetanReddy KetanReddy commented Jul 19, 2024

Cleaning up misc JS package issues after migrating to bazel-6

  • Fixing @player-ui/pubsub-plugin being renamed to @player-ui/pubsub
  • Fixing @player-ui/storybook not being published
  • Reverting renaming @player-ui/storybook to @player-ui/storybook-addon-player

Change Type (required)

Indicate the type of change your pull request is:

  • patch
  • minor
  • major

Release Notes

Fix migration issues in JS packages

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs
📦 Published PR as canary version: 0.7.5--canary.442.15327

Try this version out locally by upgrading relevant packages to 0.7.5--canary.442.15327

Version

Published prerelease version: 0.8.0-next.2

Changelog

Release Notes

JS Package Cleanup (#442)

Fix migration issues in JS packages

Does your PR have any documentation updates?

  • Updated docs
  • No Update needed
  • Unable to update docs

Bazel 6 Migration (#252)

Swaps the repo internals to use bazel@6, rules_js, bazel modules, vitest and tsup for the core + plugin builds


🚀 Enhancement

🐛 Bug Fix

🏠 Internal

📝 Documentation

Authors: 10

@KetanReddy KetanReddy added the patch Increment the patch version when merged label Jul 19, 2024
@KetanReddy KetanReddy requested a review from a team July 19, 2024 21:34
@KetanReddy KetanReddy self-assigned this Jul 19, 2024
@KetanReddy
Copy link
Member Author

/canary

Copy link

codecov bot commented Jul 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (main@bc65945). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #442   +/-   ##
=======================================
  Coverage        ?   91.71%           
=======================================
  Files           ?      338           
  Lines           ?    26798           
  Branches        ?     1938           
=======================================
  Hits            ?    24579           
  Misses          ?     2205           
  Partials        ?       14           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@KetanReddy KetanReddy marked this pull request as ready for review July 22, 2024 19:27
@KetanReddy KetanReddy requested a review from adierkens as a code owner July 22, 2024 19:27
@KetanReddy KetanReddy changed the title [WIP] JS Package Cleanup JS Package Cleanup Jul 22, 2024
@KetanReddy KetanReddy merged commit e8a73e6 into main Jul 22, 2024
11 checks passed
@KetanReddy KetanReddy deleted the maint/js-package-cleanup branch July 22, 2024 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
patch Increment the patch version when merged
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants