Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop interplay #206

Merged
merged 3 commits into from
Oct 4, 2023
Merged

Drop interplay #206

merged 3 commits into from
Oct 4, 2023

Conversation

ihostage
Copy link
Member

@mkurz
Copy link
Member

mkurz commented Oct 4, 2023

Please see my last commit I added:
You forgot the developers settings. Without having developers present in the pom file sonatype does not allow us to publish release artifacts. For snapshot it is not so strict and works without developers set.

Basically the things that are missing are from the PlayBuildBase sbt plugin .
It gets loaded automatically, see https://github.com/playframework/interplay/blob/ad1bddb900e2883f7ad78e59c70fc86603903a52/src/main/scala/interplay/PlayBuildBase.scala#L13 and applies a couple of settings and javac/scalac flags:

I now copied over the developers and the missing javac and scalac flags (I am not saying all of them make sense, I just keep them for now). I did not copy over the resolver settings since it's not necessary.

@mkurz mkurz merged commit 123f9b0 into main Oct 4, 2023
11 checks passed
@mkurz mkurz deleted the drop-interplay branch October 4, 2023 21:55
@mkurz mkurz mentioned this pull request Oct 4, 2023
@mkurz
Copy link
Member

mkurz commented Oct 4, 2023

See #211

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants