Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop interplay #447

Merged
merged 1 commit into from
Oct 5, 2023
Merged

Drop interplay #447

merged 1 commit into from
Oct 5, 2023

Conversation

ihostage
Copy link
Member

@ihostage ihostage requested a review from mkurz September 14, 2023 15:20
addSbtPlugin("com.typesafe.play" % "sbt-plugin" % sys.props.getOrElse("play.version", "2.9.0-M7"))
addSbtPlugin("com.typesafe.play" % "play-docs-sbt-plugin" % sys.props.getOrElse("play.version", "2.9.0-M7"))

addSbtPlugin("org.scalameta" % "sbt-scalafmt" % "2.5.2")
addSbtPlugin("com.typesafe" % "sbt-mima-plugin" % "1.1.3")
addSbtPlugin("de.heikoseeberger" % "sbt-header" % "5.10.0")

addSbtPlugin("com.github.sbt" % "sbt-ci-release" % "1.5.12")
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mkurz How did we release this library without sbt-ci-release plugin? 🤔

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ihostage
Copy link
Member Author

ihostage commented Oct 5, 2023

@mkurz I updated this PR by your comments from playframework/play-doc#206

Copy link
Member

@mkurz mkurz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM
The docs project does get the flags applied, etc. however that should not matter anyway at this point. If we need to set some (like -Xmigration and similar) we can do that later if needed.

@mkurz mkurz merged commit 08261f2 into main Oct 5, 2023
12 checks passed
@mkurz mkurz deleted the drop-interplay branch October 5, 2023 11:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants