[main] update sonatype profile name #679
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
octonato
changed the title
mkurz
requested changes
Dec 2, 2021
| @@ -137,8 +137,7 @@ lazy val commonSettings = Def.settings( | |||
| Compile / doc / scalacOptions ++= Seq( | |||
| // Work around 2.12 bug which prevents javadoc in nested java classes from compiling. | |||
| "-no-java-comments", | |||
| ), | |||
| sonatypeProfileName := "com.typesafe" | |||
There was a problem hiding this comment.
@octonato You removed it, but shouldn't it be set to com.typesafe.play?
There was a problem hiding this comment.
No, that's correct.
The main branch is not using Interplay any more and therefore, if you say nothing, the profile name will be the same as the groupId, so com.typesafe.play.
When we removed Interplay we had to force it to be com.typesafe, but now we want it to be the groupId.
In the 2.8.x branch, is the other way around. There we use Interplay and it sets it to com.typesafe and we need to force it to com.typesafe.play.
Confusing, no?
mkurz
approved these changes
Jan 2, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.