Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[main] update sonatype profile name #679

Merged
merged 1 commit into from
Jan 2, 2022
Merged

[main] update sonatype profile name #679

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions build.sbt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -137,8 +137,7 @@ lazy val commonSettings = Def.settings(
Compile / doc / scalacOptions ++= Seq(
// Work around 2.12 bug which prevents javadoc in nested java classes from compiling.
"-no-java-comments",
),
sonatypeProfileName := "com.typesafe"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@octonato You removed it, but shouldn't it be set to com.typesafe.play?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, that's correct.

The main branch is not using Interplay any more and therefore, if you say nothing, the profile name will be the same as the groupId, so com.typesafe.play.

When we removed Interplay we had to force it to be com.typesafe, but now we want it to be the groupId.

In the 2.8.x branch, is the other way around. There we use Interplay and it sets it to com.typesafe and we need to force it to com.typesafe.play.

Confusing, no?

)
)

lazy val root = project
Expand Down