Problem: customizing tabular view is hard #606
Conversation
|
Thibaut Born your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request. Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/ |
|
@gotcha thanks for creating this Pull Request and help improve Plone! To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass. Whenever you feel that the pull request is ready to be tested, either start all jenkins jobs pull requests by yourself, or simply add a comment in this pull request stating: With this simple comment all the jobs will be started automatically. Happy hacking! |
gotcha
changed the title
|
Thibaut Born your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request. Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/ |
|
Thibaut Born your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request. Learn about the Plone Contributor Agreement: http://docs.plone.org/develop/coredev/docs/contributors_agreement_explained.html How to add more emails to your GitHub account: https://help.github.com/articles/adding-an-email-address-to-your-github-account/ |
gotcha
changed the title
|
As suggested my @mauritsvanrees, I ported #595 to master. |
|
FTR, @ThibautBorn has signed the contributor agreement and has been added to the Plone Foundation organisation. This makes Mr.roboto complaints hard to explain. |
| if icon_cell_view is not None: | ||
| icon_cell_view.table_view = self | ||
| result.append(icon_cell_view()) | ||
| for field in self.tabular_fields: |
There was a problem hiding this comment.
For collection self.tabular_fields is inherited from collection.py and a method, not a property.
|
Sorry, I don't have time to really review this. But I agree that overriding the tabular view is a pain. |
|
Regarding the CLA complaint: Check if the commits are containing an email address and if that address is known by GitHub (in @ThibautBorn GH settings). |
| @property | ||
| def type_class(self): | ||
| return ("contenttype/" + | ||
| self.table_view.normalizeString(self.context.PortalType()) |
There was a problem hiding this comment.
You call PortalType here, but a few lines above, you use it as attribute instead of method. One is probably wrong.
I never use PortalType. I think I have only seen this sometimes in the portal_catalog.
In both cases I would use portal_type.
|
Thibaut Born your emails are not known to GitHub and thus it is impossible to know if you have signed the Plone Contributor Agreement, which is required to merge this pull request. Learn about the Plone Contributor Agreement: https://plone.org/foundation/contributors-agreement How to add more emails to your GitHub account: https://docs.github.com/en/account-and-profile/setting-up-and-managing-your-personal-account-on-github/managing-email-preferences/adding-an-email-address-to-your-github-account |
ThibautBorn
force-pushed
the
cellview6
branch
2 times, most recently
from
aab28b1
to
e7f1bc2
Compare
Solution: use views for table cells such that they can be overridden
|
@mauritsvanrees @jensens Would you take a last look ? Or am I allowed to merge ? |
|
@jenkins-plone-org please run jobs |
Solution: use views for table cells such that they can be overridden