Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve table view customizability (fix dependency) #676

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

gotcha
Copy link
Member

@gotcha gotcha commented Oct 23, 2023

Replace PR #606

  • CI should be green
  • avoid merge commits

@mister-roboto
Copy link

@gotcha thanks for creating this Pull Request and helping to improve Plone!

TL;DR: Finish pushing changes, pass all other checks, then paste a comment:

@jenkins-plone-org please run jobs

To ensure that these changes do not break other parts of Plone, the Plone test suite matrix needs to pass, but it takes 30-60 min. Other CI checks are usually much faster and the Plone Jenkins resources are limited, so when done pushing changes and all other checks pass either start all Jenkins PR jobs yourself, or simply add the comment above in this PR to start all the jobs automatically.

Happy hacking!

@mauritsvanrees
Copy link
Member

Sorry, I still have not taken time to properly look at this.
It feels like a change in the right direction, but also a change that will likely break customisations. So my gut feeling is: Plone 6.1 only.

@MrTango MrTango self-requested a review October 27, 2023 14:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants