Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed word-break:break-word from contents table tbody #5749

Merged
merged 1 commit into from
Mar 5, 2024

Conversation

ichim-david
Copy link
Member

  • Due to having small table headers such as ID or UID which meant that there was no room to show those ids

This commit fixes #5742 by removing the change made in this pull request https://github.com/plone/volto/pull/3245/files#diff-741dc58bf11002ee21b76a53bd83a19041a2dc2e06fcd838346af8ed52c040e6R143

- Due to having small table headers such as ID or UID which meant that there was no room to show those ids
Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit e49781b
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65c8ccc9edb07a0007cc9ec6

Copy link

netlify bot commented Feb 11, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit e49781b
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65c8ccc9150d10000849ca10

@ichim-david
Copy link
Member Author

ichim-david commented Feb 11, 2024

@pnicolli @sneridagh one thing that we could do is perhaps to add sticky sections for the drag, select and actions for situation where you enabled many filters that will make you scroll until you get to the actions.
See these videos for what I mean.
The current behavior with non-sticky:
https://github.com/plone/volto/assets/152852/2ea97d61-34b0-4f25-a34b-cb144e47a21e

With sticky sections:
https://github.com/plone/volto/assets/152852/1dc012d6-7385-4e70-90a5-883c8e24f955

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Now that the table scrolls properly, it makes more sense to not break words.

I also like the idea for a sticky actions column.

@sneridagh
Copy link
Member

+1 I like the idea too.

@sneridagh sneridagh merged commit 9bb5dff into main Mar 5, 2024
64 checks passed
@sneridagh sneridagh deleted the contents_5742 branch March 5, 2024 07:53
sneridagh added a commit that referenced this pull request Mar 5, 2024
* main: (46 commits)
  Removed word-break:break-word from contents table tbody (#5749)
  Fix Link to Item and Aliases view not updating content in multilingua… (#5821)
  Fix HMR problems, upgrade react-refresh and @pmmmwh/react-refresh-web… (#5833)
  Uses Plone 6.0.10.1 in tests (#5830)
  Improve wayfinding for various Volto audiences (#5809)
  Fix issue with HMR and register the same predicate-less component again (#5832)
  Reset global Form state onSubmit and onCancel in Add and Edit forms. (#5827)
  Show validation error message as string instead of list (#5808)
  Updated build-deps command to check if registry is newer than dist to force rebuild (#5825)
  Upgrade TSQ to latest, testing deployments (#5824)
  Release 18.0.0-alpha.16
  Release @plone/slate 18.0.0-alpha.9
  Release @plone/scripts 3.4.0
  Release @plone/registry 1.5.1
  Release generate-volto 9.0.0-alpha.8
  Release @plone/components 2.0.0-alpha.4
  Release @plone/client 1.0.0-alpha.13
  Several dependencies updates to 18 (#5815)
  [components] Pass down the Popover context, if any, in Select (#5823)
  [Components] Improve build, get rid of lodash, renaming Views directory, deps cleaning, upgrade StoryBook and Vite (#5822)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

content id being showed vertically (distorted) if we add some more attributes then it is showing horizontally.
3 participants