Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated build-deps command to check if registry is newer than dist to force rebuild #5825

Merged
merged 1 commit into from
Mar 3, 2024

Conversation

ichim-david
Copy link
Member

@ichim-david ichim-david commented Mar 2, 2024

After the slots merge when I wanted to bring pull request #4252 up to date
Volto crashed with config.getSlots isn't a function.
This change to build-deps checks if there are newer files within the registry folder as opposed to the dist in
which case it should run the registry compile again.
That compile then adds the getSlots config and the instance can properly run again.

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 6e1a39d
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65e371c4aacc7d0008f1670a

Copy link

netlify bot commented Mar 2, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 6e1a39d
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65e371c409cb200008bafbed

@sneridagh sneridagh merged commit 65ec519 into main Mar 3, 2024
64 checks passed
@sneridagh sneridagh deleted the build-deps-update branch March 3, 2024 16:35
sneridagh added a commit that referenced this pull request Mar 3, 2024
* main: (29 commits)
  Show validation error message as string instead of list (#5808)
  Updated build-deps command to check if registry is newer than dist to force rebuild (#5825)
  Upgrade TSQ to latest, testing deployments (#5824)
  Release 18.0.0-alpha.16
  Release @plone/slate 18.0.0-alpha.9
  Release @plone/scripts 3.4.0
  Release @plone/registry 1.5.1
  Release generate-volto 9.0.0-alpha.8
  Release @plone/components 2.0.0-alpha.4
  Release @plone/client 1.0.0-alpha.13
  Several dependencies updates to 18 (#5815)
  [components] Pass down the Popover context, if any, in Select (#5823)
  [Components] Improve build, get rid of lodash, renaming Views directory, deps cleaning, upgrade StoryBook and Vite (#5822)
  Linkcheck thinks `README.md` is `http://README.md`. Bad linkcheck, no… (#5816)
  Release 18.0.0-alpha.15
  Changes to Volto autogenerated types
  Release @plone/slate 18.0.0-alpha.8
  Release @plone/types 1.0.0-alpha.5
  Add missing @ in the literal of the prepublish script
  Release @plone/registry 1.5.0
  ...
sneridagh added a commit that referenced this pull request Mar 5, 2024
* main: (46 commits)
  Removed word-break:break-word from contents table tbody (#5749)
  Fix Link to Item and Aliases view not updating content in multilingua… (#5821)
  Fix HMR problems, upgrade react-refresh and @pmmmwh/react-refresh-web… (#5833)
  Uses Plone 6.0.10.1 in tests (#5830)
  Improve wayfinding for various Volto audiences (#5809)
  Fix issue with HMR and register the same predicate-less component again (#5832)
  Reset global Form state onSubmit and onCancel in Add and Edit forms. (#5827)
  Show validation error message as string instead of list (#5808)
  Updated build-deps command to check if registry is newer than dist to force rebuild (#5825)
  Upgrade TSQ to latest, testing deployments (#5824)
  Release 18.0.0-alpha.16
  Release @plone/slate 18.0.0-alpha.9
  Release @plone/scripts 3.4.0
  Release @plone/registry 1.5.1
  Release generate-volto 9.0.0-alpha.8
  Release @plone/components 2.0.0-alpha.4
  Release @plone/client 1.0.0-alpha.13
  Several dependencies updates to 18 (#5815)
  [components] Pass down the Popover context, if any, in Select (#5823)
  [Components] Improve build, get rid of lodash, renaming Views directory, deps cleaning, upgrade StoryBook and Vite (#5822)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants