Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix block chooser search is not focusable when clicked on add button #5867

Merged
merged 1 commit into from
May 27, 2024
Merged

Fix block chooser search is not focusable when clicked on add button #5867

merged 1 commit into from
May 27, 2024

Conversation

iRohitSingh
Copy link
Contributor

Fix #5866

Screen.Recording.2024-03-11.at.8.36.17.PM.mov

@iRohitSingh iRohitSingh requested a review from sneridagh March 11, 2024 15:06
@netlify Netlify
Copy link

netlify bot commented Mar 11, 2024 •
edited
Loading

✅ Deploy Preview for volto canceled.

Name Link
🔨 Latest commit 579e68e
🔍 Latest deploy log https://app.netlify.com/sites/volto/deploys/65ef1e06dbf62f0008c46a29

@netlify Netlify
Copy link

netlify bot commented Mar 11, 2024 •
edited
Loading

✅ Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 579e68e
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/65ef1e06ffb7660008bc533c

@iRohitSingh iRohitSingh mentioned this pull request Mar 11, 2024
Open
@iRohitSingh
Copy link
Contributor Author

@sneridagh I debugged this issue and in initial implementation there was autofocus but someone removed it. I am not able to pinpoint the person in gitblame. I readded it.

@stevepiercy
Copy link
Collaborator

@iRohitSingh it was part of this commit by @sneridagh. He did some other things with autofocus. I'm not clear what one has to do with the other.

@sneridagh
Copy link
Member

@stevepiercy which commit?

autofocus is meh for a11y things... don't know if that had to be with the removal.

/cc @ichim-david

@ichim-david
Copy link
Member

ichim-david commented Mar 19, 2024 •
edited
Loading

@stevepiercy which commit?

autofocus is meh for a11y things... don't know if that had to be with the removal.

/cc @ichim-david

@sneridagh I am in favor of adding the autofocus back as the short version.

You've probably read something similar to this mention https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/autofocus#accessibility_concerns.
I have seen examples where once you open something you focus to the first form element that is focusable such as the first input look at react-aria dialog example https://react-spectrum.adobe.com/react-aria/Dialog.html.

For us since it focuses it on the search input if you hit tab you will get to the other block items from the popup which
is not possible right now so not only are you solving the convenience of the sighted users to have the search focused but you can also now use the keyboard tab key to select a block to add which is a plus for the a11y folks that rely on keyboard navigation.

@ichim-david ichim-david self-requested a review March 19, 2024 12:00
@stevepiercy
Copy link
Collaborator

@sneridagh I can't find it now. I may have been mistaken.

@sneridagh sneridagh merged commit e87d129 into main May 27, 2024
74 checks passed
@sneridagh sneridagh deleted the input-field branch May 27, 2024 10:08
@sneridagh
Copy link
Member

ok! merging.

sneridagh added a commit that referenced this pull request May 30, 2024
@sneridagh
Merge branch 'main' into enhanceimagewidget_newbranch
7d11ba2 
* main: (60 commits)
  Object browser icon view v2 (#6054)
  Refactor TextWidget (#6020)
  [client] Remove the custom runner with bare vitest config (#6056)
  [client] Fix login mutation (#6053)
  Fix test script in monorepo root (#6051)
  Fix block chooser search is not focusable when clicked on add button (#5867)
  [@plone/types] BlockExtension as Interface types (#6049)
  Fixed querystring search query type (#6034)
  Id widget refactor (#6027)
  Release 18.0.0-alpha.32
  Release @plone/providers 1.0.0-alpha.1
  Release @plone/components 2.0.0-alpha.9
  Release @plone/client 1.0.0-alpha.15
  Release @plone/types 1.0.0-alpha.13
  Fix @plone/client deps (#6045)
  Allow X-Robots-Tag header in images/files middleware (#6043)
  Fixed showRestricted not applying when rendering a custom BlocksForm (#6026)
  change relative import to alias import (#6041)
  Build documentation and Storybook only when their files change (#6037)
  Use pnpm corepack instead of installing it in CI (#6038)
  ...
@sneridagh sneridagh mentioned this pull request Oct 10, 2024
Closed
@sneridagh
Copy link
Member

@iRohitSingh @ichim-david I'm reverting this PR because it caused a regression:#6389

Let's find an alternative whenever possible.

@sneridagh sneridagh mentioned this pull request Oct 10, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ichim-david ichim-david ichim-david approved these changes

@sneridagh sneridagh Awaiting requested review from sneridagh

Assignees
No one assigned
Labels
24 status: ready
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Block chooser search is not focusable when clicked on add button.
4 participants
@iRohitSingh @stevepiercy @sneridagh @ichim-david