Allow X-Robots-Tag header in images/files middleware #6043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
davisagli
reviewed
May 22, 2024
There was a problem hiding this comment.
@sneridagh Okay, but this isn't all we need. We want to pass X-Robots-Tag through when downloading the image data via the middleware, yes, but we also want to include it in the Volto SSR response for an image view.
(Maybe it's easier to add the robots meta tag, using react-helmet?)
davisagli
approved these changes
May 22, 2024
There was a problem hiding this comment.
@sneridagh reminded me the meta tag is already added in ContentMetadataTags.jsx. So this looks good to me.
sneridagh
added a commit
that referenced
this pull request
May 23, 2024
sneridagh
added a commit
that referenced
this pull request
May 23, 2024
sneridagh
added a commit
that referenced
this pull request
May 30, 2024
* main: (60 commits) Object browser icon view v2 (#6054) Refactor TextWidget (#6020) [client] Remove the custom runner with bare vitest config (#6056) [client] Fix login mutation (#6053) Fix test script in monorepo root (#6051) Fix block chooser search is not focusable when clicked on add button (#5867) [@plone/types] BlockExtension as Interface types (#6049) Fixed querystring search query type (#6034) Id widget refactor (#6027) Release 18.0.0-alpha.32 Release @plone/providers 1.0.0-alpha.1 Release @plone/components 2.0.0-alpha.9 Release @plone/client 1.0.0-alpha.15 Release @plone/types 1.0.0-alpha.13 Fix @plone/client deps (#6045) Allow X-Robots-Tag header in images/files middleware (#6043) Fixed showRestricted not applying when rendering a custom BlocksForm (#6026) change relative import to alias import (#6041) Build documentation and Storybook only when their files change (#6037) Use pnpm corepack instead of installing it in CI (#6038) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
📚 Documentation preview 📚: https://volto--6043.org.readthedocs.build/