Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Used resource title instead of resource type in page title. #6402

Merged
merged 4 commits into from
Oct 25, 2024

Conversation

Faakhir30
Copy link
Contributor

@Faakhir30 Faakhir30 commented Oct 13, 2024


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #6308

Copy link

netlify bot commented Oct 13, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 26871f9
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/671b5231f8fbb700089b4b5b

@stevepiercy
Copy link
Collaborator

This needs review from @plone/volto-team. I'm not sure about inserting a - into the message ID. I don't know if that would be good, bad, or doesn't matter for a11y, @plone/volto-accessibility?

@JeffersonBledsoe
Copy link
Member

I'm not sure about inserting a - into the message ID. I don't know if that would be good, bad, or doesn't matter for a11y, @plone/volto-accessibility?

No problems that I'm aware of. It's a common pattern to use it to separate out 'sections' of a title and most screen readers will skip over it and add a gap in the read-out.

All that said, I'm not sure it's a needed change here (as already mentioned) as we don't use it elsewhere so let's keep it consistent

@ichim-david ichim-david self-requested a review October 25, 2024 08:09
@stevepiercy
Copy link
Collaborator

@Faakhir30 you got two approvals, everything passes, and I think you have permission to click the green Merge button. Please do the honors!

@avoinea
Copy link
Member

avoinea commented Oct 25, 2024

@stevepiercy @Faakhir30 I think you should use the Squash and merge. @sneridagh or @davisagli can advice 🤔

@avoinea
Copy link
Member

avoinea commented Oct 25, 2024

Hmm 🤔 ! I see the other options are already disabled

@Faakhir30
Copy link
Contributor Author

Faakhir30 commented Oct 25, 2024

@Faakhir30 you got two approvals, everything passes, and I think you have permission to click the green Merge button. Please do the honors!

@stevepiercy I would have loved merged about a week ago for sure, but developers group doesnt have access to merge in Volto, ig only volto-team and plone/accessibilty teams have access.
image

@stevepiercy
Copy link
Collaborator

Ah, yes, my mistake. Volto requires Maintain role, not just Write which the Plone/Developers Team has, to merge PRs.

Screenshot 2024-10-25 at 4 13 18 AM

I'll do the honors. Thank you!

@stevepiercy stevepiercy merged commit 6b9986a into main Oct 25, 2024
69 checks passed
@stevepiercy stevepiercy deleted the edit_title_6308 branch October 25, 2024 11:16
@davisagli
Copy link
Member

Thanks @stevepiercy!

sneridagh added a commit that referenced this pull request Oct 26, 2024
* main:
  [Next.js] Better Vercel deployment (#6441)
  Replace all `yarn` appearences with `pnpm` (#6433)
  Add deprecation notices to the Upgrade guide (#6426)
  Clean up #6422 (#6443)
  Rename page title from Frontend to Volto UI (#6438)
  URL-Management control panel: Add missing translations (#6436)
  Fix broken links (#6440)
  Fix broken links (#6439)
  Used resource title instead of resource type in page title. (#6402)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Edit mode <title> doesn't describe the name of the page but instead describes the content type
6 participants