-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Used resource title instead of resource type in page title. #6402
Conversation
✅ Deploy Preview for plone-components canceled.
|
b07ba75
to
95db6ce
Compare
This needs review from @plone/volto-team. I'm not sure about inserting a |
95db6ce
to
0d31554
Compare
No problems that I'm aware of. It's a common pattern to use it to separate out 'sections' of a title and most screen readers will skip over it and add a gap in the read-out. All that said, I'm not sure it's a needed change here (as already mentioned) as we don't use it elsewhere so let's keep it consistent |
@Faakhir30 you got two approvals, everything passes, and I think you have permission to click the green Merge button. Please do the honors! |
@stevepiercy @Faakhir30 I think you should use the |
Hmm 🤔 ! I see the other options are already disabled |
@stevepiercy I would have loved merged about a week ago for sure, but |
Thanks @stevepiercy! |
* main: [Next.js] Better Vercel deployment (#6441) Replace all `yarn` appearences with `pnpm` (#6433) Add deprecation notices to the Upgrade guide (#6426) Clean up #6422 (#6443) Rename page title from Frontend to Volto UI (#6438) URL-Management control panel: Add missing translations (#6436) Fix broken links (#6440) Fix broken links (#6439) Used resource title instead of resource type in page title. (#6402)
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #6308