-
-
Notifications
You must be signed in to change notification settings - Fork 661
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Next.js] Better Vercel deployment #6441
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
stevepiercy
requested changes
Oct 25, 2024
Co-authored-by: Steve Piercy <web@stevepiercy.com>
@stevepiercy thanks! |
stevepiercy
approved these changes
Oct 26, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made some quick edits to docs and comments. LGTM!
@sneridagh needs change log entry. |
@stevepiercy since it's an experimental PoC, we agreed on not to add Changelog for now. |
@sneridagh OK, and we can skip the failing readme linkcheck. |
sneridagh
added a commit
that referenced
this pull request
Oct 26, 2024
sneridagh
added a commit
that referenced
this pull request
Oct 26, 2024
* main: [Next.js] Better Vercel deployment (#6441) Replace all `yarn` appearences with `pnpm` (#6433) Add deprecation notices to the Upgrade guide (#6426) Clean up #6422 (#6443) Rename page title from Frontend to Volto UI (#6438) URL-Management control panel: Add missing translations (#6436) Fix broken links (#6440) Fix broken links (#6439) Used resource title instead of resource type in page title. (#6402)
sneridagh
added a commit
that referenced
this pull request
Oct 30, 2024
* main: (111 commits) Moved `applyBlockDefaults` one component up so the style is computed correctly (#6451) Fix useSelector is returned a different result when called with the s… (#6450) Fix page changes not being announced by assistive technology when navigating using the client-side router (#5288) BlockStyleWrapper aware of block themes (#6445) A11y: Wrap ToC Block within nav tag (#6084) Fix backend error when there is no query supplied (#6423) Added upgrade guide fix for HMR (#6446) Fix CSS lint in Volto Slate (#6444) Release 18.0.0-alpha.47 Release generate-volto 9.0.0-alpha.20 Release @plone/scripts 3.7.0 Release @plone/registry 2.0.0-alpha.0 Improve @plone/registry release-it config `@plone/registry` as ESM module, move to TS, complete documentation (#6399) [Next.js] Better Vercel deployment (#6441) Replace all `yarn` appearences with `pnpm` (#6433) Add deprecation notices to the Upgrade guide (#6426) Clean up #6422 (#6443) Rename page title from Frontend to Volto UI (#6438) URL-Management control panel: Add missing translations (#6436) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@pnicolli to integrate with your Next.js branch