BlockStyleWrapper aware of block themes #6445
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for plone-components canceled.
|
stevepiercy
requested changes
Oct 28, 2024
davisagli
reviewed
Oct 29, 2024
| * @param {string} prefix The prefix (could be dragged from a recursive call, initially empty) | ||
| * @return {Object} The style object ready to be passed as prop | ||
| */ | ||
| export const buildStyleObjectFromData = (obj = {}, prefix = '') => { | ||
| export const buildStyleObjectFromData = (data = {}, prefix = '') => { |
There was a problem hiding this comment.
You could easily make it non-breaking by making it accept either obj or data
There was a problem hiding this comment.
Done, I had to detect that we have a full block by testing if @type is present. Take a look now.
Co-authored-by: Steve Piercy <web@stevepiercy.com>
sneridagh
force-pushed
the
stylewrapperenhancements
branch
2 times, most recently
from
810ad5a
to
4176f81
Compare
* main: Fix backend error when there is no query supplied (#6423)
stevepiercy
approved these changes
Oct 29, 2024
sneridagh
added a commit
that referenced
this pull request
Oct 30, 2024
* main: (111 commits) Moved `applyBlockDefaults` one component up so the style is computed correctly (#6451) Fix useSelector is returned a different result when called with the s… (#6450) Fix page changes not being announced by assistive technology when navigating using the client-side router (#5288) BlockStyleWrapper aware of block themes (#6445) A11y: Wrap ToC Block within nav tag (#6084) Fix backend error when there is no query supplied (#6423) Added upgrade guide fix for HMR (#6446) Fix CSS lint in Volto Slate (#6444) Release 18.0.0-alpha.47 Release generate-volto 9.0.0-alpha.20 Release @plone/scripts 3.7.0 Release @plone/registry 2.0.0-alpha.0 Improve @plone/registry release-it config `@plone/registry` as ESM module, move to TS, complete documentation (#6399) [Next.js] Better Vercel deployment (#6441) Replace all `yarn` appearences with `pnpm` (#6433) Add deprecation notices to the Upgrade guide (#6426) Clean up #6422 (#6443) Rename page title from Frontend to Volto UI (#6438) URL-Management control panel: Add missing translations (#6436) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #