Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix site setup access at toolbar by using @actions endpoint. #6413

Merged
merged 3 commits into from
Oct 22, 2024

Conversation

Faakhir30
Copy link
Contributor

@Faakhir30 Faakhir30 commented Oct 17, 2024


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #6355

Avoiding calling Actions get API again by passing through the parent component, as the toolbar already has access to actions.

Copy link

netlify bot commented Oct 17, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 6fa8ce9
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/67169d7c0dca670008028cec

Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sprinkle a little MyST syntax for the change log. Otherwise LGTM, but needs a technical review.

packages/volto/news/6355.bugfix Outdated Show resolved Hide resolved
Copy link
Member

@JeffersonBledsoe JeffersonBledsoe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll test over the weekend, but the code seems fine apart from using lodash

Signed-off-by: Faakhir30 <zahidfaakhir@gmail.com>
Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

In the future, please don't rebase and force-push each commit. It makes it hard to review what changed. We can squash the commits when we merge.

@davisagli davisagli merged commit 27120d9 into main Oct 22, 2024
68 checks passed
@davisagli davisagli deleted the fix_site_setup_access branch October 22, 2024 03:06
sneridagh added a commit that referenced this pull request Oct 22, 2024
* main: (23 commits)
  Aliases control panel: Improve layout and add CSV upload (#6421)
  Fix site setup access at toolbar by using @actions endpoint. (#6413)
  Remove last CI tests still in 18 (#6418)
  Node 22 as LTS, main and recommended Volto version (#6371)
  Refactor Aliases control panel and support new filters (#6414)
  Remove the Plone app from apps folder (#6415)
  Release generate-volto 9.0.0-alpha.19
  Release @plone/providers 1.0.0-alpha.3
  Release @plone/components 2.0.0-alpha.16
  Release @plone/client 1.0.0-alpha.19
  Release @plone/types 1.0.0-alpha.21
  Some types improvements/fixes (#6412)
  [providers] Improve and group providers (#6069)
  Adjust the path to perform a proper `git diff` between the cached and… (#6410)
  Test whether commenting out the `ignore` command has any affect on the Netlify build.
  support depth in getNavigationQuery (#6400)
  Update caniuse Oct24 (#6408)
  Upgraded nextjs deps and configuration (#6388)
  Update `typescript` and `vitest` everywhere (#6407)
  Remove all traces of Jest 24 in core (#6406)
  ...
sneridagh added a commit that referenced this pull request Oct 25, 2024
* main:
  Client transforms for reducer data (#6422)
  (fix): Enable Volto Login to Redirect Back to Original Route After Authentication  (#6419)
  Test with plone.restapi 9.8.0 (#6430)
  Add German translations for URL management control panel (#6429)
  URL Management control panel: add Edit feature (#6425)
  Remove SEAMLESS mention in bootstrap (#6424)
  Aliases control panel: Improve layout and add CSV upload (#6421)
  Fix site setup access at toolbar by using @actions endpoint. (#6413)
  Remove last CI tests still in 18 (#6418)
  Node 22 as LTS, main and recommended Volto version (#6371)
  Refactor Aliases control panel and support new filters (#6414)
  Remove the Plone app from apps folder (#6415)
  Release generate-volto 9.0.0-alpha.19
  Release @plone/providers 1.0.0-alpha.3
  Release @plone/components 2.0.0-alpha.16
  Release @plone/client 1.0.0-alpha.19
  Release @plone/types 1.0.0-alpha.21
  Some types improvements/fixes (#6412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PersonalTools/ Site Setup assumes Site Administrators have the correct permission for the site setup action
4 participants