-
-
Notifications
You must be signed in to change notification settings - Fork 660
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix site setup access at toolbar by using @actions endpoint. #6413
Conversation
✅ Deploy Preview for plone-components canceled.
|
00d1795
to
1093306
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sprinkle a little MyST syntax for the change log. Otherwise LGTM, but needs a technical review.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'll test over the weekend, but the code seems fine apart from using lodash
1093306
to
bfa4841
Compare
bfa4841
to
4de9753
Compare
Signed-off-by: Faakhir30 <zahidfaakhir@gmail.com>
4de9753
to
35e9050
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
In the future, please don't rebase and force-push each commit. It makes it hard to review what changed. We can squash the commits when we merge.
* main: (23 commits) Aliases control panel: Improve layout and add CSV upload (#6421) Fix site setup access at toolbar by using @actions endpoint. (#6413) Remove last CI tests still in 18 (#6418) Node 22 as LTS, main and recommended Volto version (#6371) Refactor Aliases control panel and support new filters (#6414) Remove the Plone app from apps folder (#6415) Release generate-volto 9.0.0-alpha.19 Release @plone/providers 1.0.0-alpha.3 Release @plone/components 2.0.0-alpha.16 Release @plone/client 1.0.0-alpha.19 Release @plone/types 1.0.0-alpha.21 Some types improvements/fixes (#6412) [providers] Improve and group providers (#6069) Adjust the path to perform a proper `git diff` between the cached and… (#6410) Test whether commenting out the `ignore` command has any affect on the Netlify build. support depth in getNavigationQuery (#6400) Update caniuse Oct24 (#6408) Upgraded nextjs deps and configuration (#6388) Update `typescript` and `vitest` everywhere (#6407) Remove all traces of Jest 24 in core (#6406) ...
* main: Client transforms for reducer data (#6422) (fix): Enable Volto Login to Redirect Back to Original Route After Authentication (#6419) Test with plone.restapi 9.8.0 (#6430) Add German translations for URL management control panel (#6429) URL Management control panel: add Edit feature (#6425) Remove SEAMLESS mention in bootstrap (#6424) Aliases control panel: Improve layout and add CSV upload (#6421) Fix site setup access at toolbar by using @actions endpoint. (#6413) Remove last CI tests still in 18 (#6418) Node 22 as LTS, main and recommended Volto version (#6371) Refactor Aliases control panel and support new filters (#6414) Remove the Plone app from apps folder (#6415) Release generate-volto 9.0.0-alpha.19 Release @plone/providers 1.0.0-alpha.3 Release @plone/components 2.0.0-alpha.16 Release @plone/client 1.0.0-alpha.19 Release @plone/types 1.0.0-alpha.21 Some types improvements/fixes (#6412)
If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.
Closes #6355
Avoiding calling
Actions
get API again by passing through the parent component, as the toolbar already has access toactions
.