Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove SEAMLESS mention in bootstrap #6424

Merged
merged 4 commits into from
Oct 23, 2024
Merged

Conversation

sneridagh
Copy link
Member


If your pull request closes an open issue, include the exact text below, immediately followed by the issue number. When your pull request gets merged, then that issue will close automatically.

Closes #

Copy link

netlify bot commented Oct 22, 2024

Deploy Preview for plone-components canceled.

Name Link
🔨 Latest commit 2d18ace
🔍 Latest deploy log https://app.netlify.com/sites/plone-components/deploys/67189cc03784120008936598

Copy link
Member

@davisagli davisagli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe it wou

packages/volto/src/start-server.js Outdated Show resolved Hide resolved
Copy link
Collaborator

@stevepiercy stevepiercy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor change to news, else I approve, pending resolution of @davisagli's comment.

packages/volto/news/6424.internal Outdated Show resolved Hide resolved
packages/volto/src/start-server.js Outdated Show resolved Hide resolved
@davisagli
Copy link
Member

@stevepiercy I'm suggesting to keep this line only and always log the API URL: console.log(API server (API_PATH) is set to: ${app.apiPath});

@sneridagh
Copy link
Member Author

@davisagli @stevepiercy done!

@davisagli davisagli merged commit fc7757f into main Oct 23, 2024
68 checks passed
@davisagli davisagli deleted the removeseamlessnoticefrombootstrap branch October 23, 2024 14:58
sneridagh added a commit that referenced this pull request Oct 24, 2024
* main:
  Test with plone.restapi 9.8.0 (#6430)
  Add German translations for URL management control panel (#6429)
  URL Management control panel: add Edit feature (#6425)
  Remove SEAMLESS mention in bootstrap (#6424)
sneridagh added a commit that referenced this pull request Oct 25, 2024
* main:
  Client transforms for reducer data (#6422)
  (fix): Enable Volto Login to Redirect Back to Original Route After Authentication  (#6419)
  Test with plone.restapi 9.8.0 (#6430)
  Add German translations for URL management control panel (#6429)
  URL Management control panel: add Edit feature (#6425)
  Remove SEAMLESS mention in bootstrap (#6424)
  Aliases control panel: Improve layout and add CSV upload (#6421)
  Fix site setup access at toolbar by using @actions endpoint. (#6413)
  Remove last CI tests still in 18 (#6418)
  Node 22 as LTS, main and recommended Volto version (#6371)
  Refactor Aliases control panel and support new filters (#6414)
  Remove the Plone app from apps folder (#6415)
  Release generate-volto 9.0.0-alpha.19
  Release @plone/providers 1.0.0-alpha.3
  Release @plone/components 2.0.0-alpha.16
  Release @plone/client 1.0.0-alpha.19
  Release @plone/types 1.0.0-alpha.21
  Some types improvements/fixes (#6412)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants