Improve parsing logic around << #662
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
June 24, 2023 00:22
|
@edublancas can you please check if this error has occurred before! |
|
@anupam-tiwari: yeah, this is the tcl problem I mentioned in the morning meeting. I re-ran the CI, let's see if it passes now. next time the CI fails unexpectedly, check the logs. if you find references to |
edublancas
requested changes
Jun 27, 2023
edublancas
requested changes
Jun 27, 2023
added 3 commits
June 28, 2023 08:03
edublancas
requested changes
Jun 28, 2023
|
@edublancas can you please review this one! |
edublancas
requested changes
Jul 6, 2023
added 2 commits
July 5, 2023 21:42
|
@edublancas does this look good? |
neelasha23
reviewed
Jul 11, 2023
neelasha23
reviewed
Jul 11, 2023
neelasha23
reviewed
Jul 11, 2023
yafimvo
reviewed
Jul 11, 2023
There was a problem hiding this comment.
I think it looks good. Please address @neelasha23 notes and I think we can merge.
|
Looks good! |
edublancas
requested changes
Jul 12, 2023
edublancas
approved these changes
Jul 13, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe your changes
Issue number
Closes #610
Checklist before requesting a review
pkgmt format📚 Documentation preview 📚: https://jupysql--662.org.readthedocs.build/en/662/