Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve parsing logic around << #662

Merged
merged 31 commits into from
Jul 13, 2023
Merged

Improve parsing logic around << #662

Changes from 4 commits
Commits
Show all changes
31 commits
Select commit Hold shift + click to select a range
ce44b2b
initial
Jun 22, 2023
fe33c06
Merge branch 'ploomber:master' into improve-parsing-logic
anupam-tiwari Jun 23, 2023
beac8bf
Merge branch 'ploomber:master' into improve-parsing-logic
anupam-tiwari Jun 24, 2023
10e2d51
changelog
Jun 24, 2023
5ecc46c
rebase
Jun 24, 2023
d2f8778
linted
Jun 24, 2023
4b5342b
pytest
Jun 24, 2023
068af3b
pytest-newline
Jun 24, 2023
3f30559
lint
Jun 24, 2023
19d1c13
pytest
Jun 24, 2023
1dbf7a5
Empty-Commit
Jun 27, 2023
43e7eae
added more test cases
Jun 27, 2023
dc78d0b
Merge branch 'ploomber:master' into improve-parsing-logic
anupam-tiwari Jun 27, 2023
44dac2b
Empty-Commit
Jun 27, 2023
96457fd
conflict
Jun 28, 2023
61bf355
added more test case
Jun 28, 2023
e3f589e
resolve merge
Jun 28, 2023
c35789f
Merge branch 'ploomber:master' into improve-parsing-logic
anupam-tiwari Jun 29, 2023
cfe15f6
refactor
Jun 29, 2023
0def7c4
test
Jun 29, 2023
3941ff5
lint
Jun 29, 2023
a5a0231
Merge branch 'ploomber:master' into improve-parsing-logic
anupam-tiwari Jun 30, 2023
5222cf3
pytest
Jun 30, 2023
18e4825
added test and removed print
Jul 3, 2023
6aff210
changes
Jul 6, 2023
1b3f451
Empty-Commit
Jul 10, 2023
8f3695d
added more edge cases
Jul 12, 2023
ecf706f
removed else
Jul 12, 2023
1d7c626
resolve merge
Jul 12, 2023
bc585a3
removed test
Jul 12, 2023
a3e43fb
clear tests
Jul 12, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 14 additions & 5 deletions src/tests/test_parse.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -88,20 +88,29 @@ def test_parse_shovel_operator():
"dest =<< SELECT * FROM work",
"dest = << SELECT * FROM work",
"dest=<< SELECT * FROM work",
"dest<<SELECT * FROM work",
"dest <<SELECT * FROM work",
"dest << SELECT * FROM work",
"dest=<<SELECT * FROM work",
anupam-tiwari marked this conversation as resolved.
Show resolved Hide resolved
"dest=<< SELECT * FROM work",
"dest = << SELECT * FROM work",
"dest = <<SELECT * FROM work",
"dest =<<SELECT * FROM work",
"dest =<< SELECT * FROM work",
"dest= << SELECT * FROM work",
],
)
def test_parse_return_shovel_operator(input_string, ip):
result = {
result_var_true = {
"connection": "",
"sql": "SELECT * FROM work",
"result_var": "dest",
"return_result_var": True,
}
assert parse(input_string, empty_config) == result
result_var_false = {
"connection": "",
"sql": "SELECT * FROM work",
"result_var": "dest",
"return_result_var": False,
}
assert parse(input_string, empty_config) == result_var_true or result_var_false
edublancas marked this conversation as resolved.
Show resolved Hide resolved


def test_parse_connect_plus_shovel():
Expand Down