Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Deprecating legacy plot API #669

Closed
wants to merge 10 commits into from
Closed

Deprecating legacy plot API #669

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
10 commits
Select commit Hold shift + click to select a range
6059bf8
Update run.py
tl3119 Jun 26, 2023
60d9285
Update CHANGELOG.md
tl3119 Jun 26, 2023
57fa5c0
Update warning message
tl3119 Jun 27, 2023
c2514eb
Merge pull request #18 from ploomber/master
tl3119 Jun 27, 2023
9aae533
Update run.py
tl3119 Jun 27, 2023
b6189af
Merge branch 'master' into deprecating-legacy-plot-API
edublancas Jun 28, 2023
fdd9795
Update test case
tl3119 Jun 29, 2023
ecaef4d
Merge pull request #19 from ploomber/master
tl3119 Jun 29, 2023
976ddbb
Update test case using pytest.parametrizera
tl3119 Jun 30, 2023
6a88eaa
Merge pull request #21 from ploomber/master
tl3119 Jun 30, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,7 @@
* [Doc] Document --persist-replace in API section (#539)
* [Fix] Fixed CI issue by updating `invalid_connection_string_duckdb` in `test_magic.py` (#631)
* [Fix] Refactored `ResultSet` to lazy loading (#470)
* [Fix] Showed depcrecation warnings message for plot API ([#513](https://github.com/ploomber/jupysql/issues/513))
tl3119 marked this conversation as resolved.
Show resolved Hide resolved

## 0.7.9 (2023-06-19)

Expand Down
21 changes: 21 additions & 0 deletions src/sql/run.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -233,6 +233,13 @@ def pie(self, key_word_sep=" ", title=None, **kwargs):
Any additional keyword arguments will be passed
through to ``matplotlib.pylab.pie``.
"""
warnings.warn(
(
".pie() will be removed in a future version,"
"please use %sqlplot bar. If you need help migrating,"
tl3119 marked this conversation as resolved.
Show resolved Hide resolved
"send us a message: https://ploomber.io/community"
)
tl3119 marked this conversation as resolved.
Show resolved Hide resolved
)
self.guess_pie_columns(xlabel_sep=key_word_sep)
import matplotlib.pylab as plt

Expand Down Expand Up @@ -261,6 +268,13 @@ def plot(self, title=None, **kwargs):
Any additional keyword arguments will be passed
through to ``matplotlib.pylab.plot``.
"""
warnings.warn(
(
".plot() will be removed in a future version."
"If you need help migrating, send us a message: "
"https://ploomber.io/community"
)
)
import matplotlib.pylab as plt

self.guess_plot_columns()
Expand Down Expand Up @@ -302,6 +316,13 @@ def bar(self, key_word_sep=" ", title=None, **kwargs):
Any additional keyword arguments will be passed
through to ``matplotlib.pylab.bar``.
"""
warnings.warn(
(
".bar() will be removed in a future version,"
"please use %sqlplot bar. If you need help migrating,"
"send us a message: https://ploomber.io/community"
)
)
import matplotlib.pylab as plt

ax = plt.gca()
Expand Down
Loading