Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecating legacy plot API #669

Closed
wants to merge 10 commits into from

Conversation

tl3119
Copy link

@tl3119 tl3119 commented Jun 26, 2023

Describe your changes

Showed depcrecation warnings message for plot API

Issue number

Closes #513

Checklist before requesting a review


📚 Documentation preview 📚: https://jupysql--669.org.readthedocs.build/en/669/quick-start.html

Copy link

@edublancas edublancas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

make the warnings more specific

.plot() this one will be generic as there is no equivalent: .plot() will be removed in a future version. If you need help migrating, send us a message: https://ploomber.io/community

.bar(): .bar() will be removed in a future version, please use %sqlplot bar. If you need help migrating, send us a message: https://ploomber.io/community

.pie(): .bar() will be removed in a future version, please use %sqlplot pie. If you need help migrating, send us a message: https://ploomber.io/community

@tl3119
Copy link
Author

tl3119 commented Jun 27, 2023

make the warnings more specific

.plot() this one will be generic as there is no equivalent: .plot() will be removed in a future version. If you need help migrating, send us a message: https://ploomber.io/community

.bar(): .bar() will be removed in a future version, please use %sqlplot bar. If you need help migrating, send us a message: https://ploomber.io/community

.pie(): .bar() will be removed in a future version, please use %sqlplot pie. If you need help migrating, send us a message: https://ploomber.io/community

Update it now

src/sql/run.py Outdated Show resolved Hide resolved
@edublancas
Copy link

is this ready @tl3119 ? don't forget to re-request a review when ready

@tl3119
Copy link
Author

tl3119 commented Jun 28, 2023

is this ready @tl3119 ? don't forget to re-request a review when ready

Yes, got it. This is ready now.

@tl3119 tl3119 requested a review from edublancas June 28, 2023 04:42
Copy link

@yafimvo yafimvo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tl3119 Can you please add 3 tests that check the warning message?

CHANGELOG.md Outdated Show resolved Hide resolved
src/sql/run.py Show resolved Hide resolved
@tl3119
Copy link
Author

tl3119 commented Jun 29, 2023

@tl3119 Can you please add 3 tests that check the warning message?

Sure, I have added the tests now.

src/tests/test_run.py Outdated Show resolved Hide resolved
@tl3119 tl3119 requested a review from edublancas June 30, 2023 17:39
@edublancas edublancas closed this Jul 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

deprecating legacy plot API
3 participants