Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecating legacy plot API #513

Closed
edublancas opened this issue May 24, 2023 · 5 comments · Fixed by #870
Closed

deprecating legacy plot API #513

edublancas opened this issue May 24, 2023 · 5 comments · Fixed by #870
Assignees

Comments

@edublancas
Copy link

once #508 is merged, we should start showing deprecation warnings:

def pie(self, key_word_sep=" ", title=None, **kwargs):

def bar(self, key_word_sep=" ", title=None, **kwargs):

and tell people they should use the %sqlplot API

@tl3119
Copy link

tl3119 commented Jun 23, 2023

So, for this issue, we should not use the pie and bar function in run.py. Instead, we should use %sqlplot defined in plot.py. So we need to show a warning in the run.py to tell the user they should use the %sqlplot API?

@edublancas
Copy link
Author

correct.

@edublancas
Copy link
Author

@bryannho let's work on getting the PR merged. you have some issues in the CI so merge from master. i think that'll fix it

@bryannho
Copy link

bryannho commented Sep 7, 2023

got it, will create a new PR to merge from master

@edublancas
Copy link
Author

I see you created a new PR, that's fine but for next time there's no need to do it, you can just update the existing PR and merge from master to that PR

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants