Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

513 deprecating legacy plot api #849

Closed
wants to merge 2 commits into from
Closed

513 deprecating legacy plot api #849

wants to merge 2 commits into from

Conversation

bryannho
Copy link

@bryannho bryannho commented Aug 29, 2023 •
edited by github-actions bot
Loading

Describe your changes

  • Added deprecation warnings for legacy plot functions: .pie(), .bar(), and .plot()
  • Added tests for deprecation warning messages

Issue number

Closes #513

Checklist before requesting a review

📚 Documentation preview 📚: https://jupysql--849.org.readthedocs.build/en/849/

@bryannho bryannho marked this pull request as ready for review August 29, 2023 22:47
@edublancas
Copy link

closing in favor of #870

@edublancas edublancas closed this Sep 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@edublancas edublancas Awaiting requested review from edublancas edublancas is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecating legacy plot API
2 participants
@bryannho @edublancas