-
Notifications
You must be signed in to change notification settings - Fork 76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
513 Deprecating Legacy Plot API #870
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please ensure tests are passing before requesting a review
I was able to identify and fix the matplotlib bug. The tests I wrote in |
@bryannho no need to respond to the PR comments when you begin working on stuff. it's fine if you respond to them after you finished the changes |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please review our contribution guidelines: https://ploomber-contributing.readthedocs.io/en/latest/contributing/responding-pr-review.html
when responding to PR comments, you need to add a link to the specific changes, so the reviewer can quickly spot them. add the corresponding links and request a review again
Describe your changes
Issue number
Closes #513
Checklist before requesting a review
pkgmt format
📚 Documentation preview 📚: https://jupysql--870.org.readthedocs.build/en/870/