adjustments to webpack to improve build speed #281
Conversation
| @@ -57,12 +58,15 @@ module.exports = (env, argv) => { | |||
| module: { | |||
| rules: [ | |||
| { | |||
| exclude: /node_modules/, | |||
There was a problem hiding this comment.
@alexcjohnson, curious what your thought on this exclusion is?
There was a problem hiding this comment.
Yes, it's normal to exclude node_modules as much as you can. In some cases we've had to explicitly include certain external modules in the babel transpilation step - see eg dcc - because those modules have started distributing their code using more modern JS than we accept in our bundles.
But if we're sure the es-check command included as postbuild in our package.json is running as part of CI and succeeding, then this is fine. It's currently set to es2017 which fits our general intent to support 7-year-old browsers.
There was a problem hiding this comment.
As a note, AG Grid looks to only support the two latest major browsers versions.
https://www.ag-grid.com/react-data-grid/supported-browsers/
This might cause some conflicts eventually.
|
One more minor (and unrelated) item I found when I was updating the docs recently: Console msg:
Do you think you could include this small update in this PR? |
|
Oh. Interesting. Is it to be declared as a prop? The name didn't change... |
|
It would be nice to still handle this in the component rather than the dash app. Just needs to be set in the |
|
Yeah. It would be in the component. |
There was a problem hiding this comment.
🚀 Looks great.
I am seeing:
tests/test_cell_data_type_override.py::test_cd001_cell_data_types_override FAILED [ 5%]
E selenium.common.exceptions.TimeoutException: Message: text -> 17/01/2024 not found within 10s, found: 04/02/11720
and:
tests/test_popupparent.py::test_pp001_popupParent FAILED [ 60%]
E selenium.common.exceptions.NoSuchElementException: Message: no such element: Unable to locate element: {"method":"css selector","selector":"body > .ag-popup .mantine-Select-input"}
failing locally but I believe this is unrelated to this PR.
This is a great change! I'm seeing on my M1 Pro:
npm run build 10.78s user 1.12s system 167% cpu 7.114 total
And a brutal:
npm run build 233.24s user 13.03s system 130% cpu 3:09.10 total
on main. Good stuff thank you @BSd3v!
adjustments to webpack to improve build speed