Selected rows fixes #283

BSd3v · 2024-04-09T04:13:20Z

adding timeouts to keep async processes together

…wer version

- adding timeouts to keep async processes together

…al into selectedRows-fixes

brifordwylie · 2024-04-10T03:56:52Z

this is looking promising. I tried to check out the branch and test it out (even before merge) just to see if my test case would work. I got an error when importing the dash_ag_grid module (might be pilot error). Here's the reproduction steps...

git clone git@github.com:BSd3v/dash-ag-grid-real.git dash-ag-grid-beta
cd dash-ag-grid-beta
<commit = commit 7acd81ea (HEAD -> selectedRows-fixes, origin/selectedRows-fixes)>
npm i npm run build
pip install -e .

Then just try importing the package..

ipython
In [1]: import dash_ag_grid
---------------------------------------------------------------------------
ModuleNotFoundError                       Traceback (most recent call last)
Cell In[1], line 1
----> 1 import dash_ag_grid

File ~/work/dash-ag-grid-beta/dash_ag_grid/__init__.py:10
      7 import dash as _dash
      9 # noinspection PyUnresolvedReferences
---> 10 from ._imports_ import *
     11 from ._imports_ import __all__
     13 if not hasattr(_dash, '__plotly_dash') and not hasattr(_dash, 'development'):

ModuleNotFoundError: No module named 'dash_ag_grid._imports_'

BSd3v · 2024-04-10T10:16:38Z

To run from a branch you need to build the package.

npm i
npm run build

Doing them on the same line without an & i think won't work.

brifordwylie · 2024-04-10T13:30:04Z

Ah, silly me... I think the Contributing.md shows them smooshed together. Anyway running my test code against your branch looks good... I can callback/update the table with "columnDefs", "rowData", "selectedRows" and it all looks like it working properly. Thanks a bunch for the fix. Looking forward to new PyPI version when you get a chance :)

(update) The only small wrinkle is that this callback gets called twice, so there seems to be a 'bounce' that happens... it gets called once as a result of the callback that outputs the 'selectedRows" and then it appears to get called again from the widget itself...

@app.callback(Output("selected-row-info", "children"), Input("my-table", "selectedRows"))
def update_selected_row_info(selected_rows):
    selected_row_info = f"Selected Rows: {selected_rows}"
    print(selected_row_info)
    return selected_row_info

ndrezn · 2024-04-16T14:11:51Z

.circleci/config.yml

+            pip uninstall -y pytest
+            pip install 'pytest<8.1.0'


Why is there an uninstall step here? Also, why pin at <8.1.0?

Pytest has an issue with something and was failing. Reverting back to a lower version solved the issue.

ndrezn · 2024-04-16T14:17:25Z

src/lib/fragments/AgGrid.react.js

        this.reference = React.createRef();
        this.pendingChanges = null;
+        this.dataUpdates = false;


What are the new pauseSelections/dataUpdates props for?

pauseSelections isnt new, its to keep systematic adjustments from triggering the onSelectionChanged, as far as dataUpdates its to be used in the event of rowData pushed from the server, this way it can ignore selection events. As this clears out the selectedRows if there is no data there:

rowData became a async process, so both were triggered at the same time. But because the rowData was updating, when the selectedRows were trying to be applied the grid was essentially empty.

Got it. Just wondering, is there an open ticket that describes these issues? #274 looks like it's describing this..?

Yes, this is linked with the two issues already. :)

aha... yep catching up to you hah

ndrezn · 2024-04-16T14:20:03Z

.circleci/config.yml

-      - browser-tools/install-browser-tools:
-          chrome-version: 116.0.5845.96
-          firefox-version: 116.0.3
+      - browser-tools/install-chrome


These diffs are all coming from #281 right? So we'll need to merge #281 first, rebase, then merge in these changes..?

Yes. That is correct.

ndrezn · 2024-04-16T14:52:04Z

tests/test_selected_rows.py

@@ -95,3 +97,75 @@ def selected(n):
    dash_duo.wait_for_text_to_equal(
        "#selections-single-output", "You selected athlete: Natalie Coughlin"
    )
+
+def test_sr2_selected_rows_rowdata(dash_duo):


Reviewing the test cases in #274:

We're covering:

Cannot output rowData and selectedRows in the same callback

But confirming this covers:

Inconsistent data type when selectedRows is an input depending how selectedRows was specified

When using rowIds and checkbox selection, the checkboxes are never visibly selected

Could you add a comment to this test describing these cases as well so it's clear what it's testing for?

This example is much clearer and more concise overall than the originals, kudos for the MRE!

ndrezn · 2024-04-16T14:53:19Z

tests/test_selected_rows.py

+        selected_rows = df.head(1).to_dict("records")
+        return column_defs, row_data, selected_rows


Nice test for selecting the first row for #282 👍

…ections

adjustments to webpack to improve build speed

ndrezn

💃 Please rebase from main and then I can merge! Nice change and great test case!

- adding timeouts to keep async processes together

…ections

…al into selectedRows-fixes

BSd3v · 2024-04-22T23:37:10Z

Closed as this had rebasing issues, replaced by:

#290

BSd3v and others added 15 commits April 4, 2024 16:23

adjustments to webpack to improve build speed

caac0a3

Merge branch 'plotly:main' into webpack-adjustments

c5d1723

updating circleci browser-tools to match dash

2f4bb82

updating to latest version of chrome

b6a32d7

altering version of chrome

3d4bdae

adjusting verison of chrome

148d326

adjusting to install from the circleci instead of specific versions

dc90534

adding extra pytest install

fabaf77

updating image to 3.12.1 vs 3.9.9

e276e01

reverting to 3.9.9 and uninstall pytest to reinstall pytest with a lo…

a76e43b

…wer version

fixing tyop

3cf29bd

fixing selectedRows

7fb3913

- adding timeouts to keep async processes together

Update test_column_state.py

f7ef79e

adding test for adding rowData at the same time as selectedRows

f2c2052

Merge branch 'selectedRows-fixes' of github.com:BSd3v/dash-ag-grid-re…

7acd81e

…al into selectedRows-fixes

This was linked to issues Apr 9, 2024

Several issues with selectedRows as an output #274

Closed

Automatically select the first row #282

Closed

ndrezn reviewed Apr 16, 2024

View reviewed changes

BSd3v and others added 2 commits April 16, 2024 11:59

adding test for selectedRows and the different ways for perform sel…

6a917f3

…ections

Merge pull request plotly#281 from BSd3v/webpack-adjustments

434bd13

adjustments to webpack to improve build speed

ndrezn approved these changes Apr 22, 2024

View reviewed changes

BSd3v added 2 commits April 22, 2024 16:58

fixing selectedRows

9be0cfe

- adding timeouts to keep async processes together

adding test for adding rowData at the same time as selectedRows

a889ebc

BSd3v and others added 3 commits April 22, 2024 16:58

Update test_column_state.py

214ead8

adding test for selectedRows and the different ways for perform sel…

30d9d4c

…ections

Merge branch 'selectedRows-fixes' of github.com:BSd3v/dash-ag-grid-re…

e656dcf

…al into selectedRows-fixes

ndrezn mentioned this pull request Apr 22, 2024

Fix selected rows issues #290

Merged

BSd3v closed this Apr 22, 2024

This was unlinked from issues Apr 23, 2024

Several issues with selectedRows as an output #274

Closed

Automatically select the first row #282

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Selected rows fixes #283

Selected rows fixes #283

BSd3v commented Apr 9, 2024 •

edited

Loading

brifordwylie commented Apr 10, 2024 •

edited

Loading

BSd3v commented Apr 10, 2024 •

edited

Loading

brifordwylie commented Apr 10, 2024 •

edited

Loading

ndrezn Apr 16, 2024

BSd3v Apr 16, 2024

ndrezn Apr 16, 2024

BSd3v Apr 16, 2024

ndrezn Apr 16, 2024 •

edited

Loading

BSd3v Apr 16, 2024

ndrezn Apr 16, 2024

ndrezn Apr 16, 2024

BSd3v Apr 16, 2024

ndrezn Apr 16, 2024 •

edited

Loading

ndrezn Apr 16, 2024

ndrezn left a comment

BSd3v commented Apr 22, 2024

		selected_rows = df.head(1).to_dict("records")
		return column_defs, row_data, selected_rows

Selected rows fixes #283

Selected rows fixes #283

Conversation

BSd3v commented Apr 9, 2024 • edited Loading

brifordwylie commented Apr 10, 2024 • edited Loading

BSd3v commented Apr 10, 2024 • edited Loading

brifordwylie commented Apr 10, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ndrezn Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ndrezn Apr 16, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

ndrezn left a comment

Choose a reason for hiding this comment

BSd3v commented Apr 22, 2024

BSd3v commented Apr 9, 2024 •

edited

Loading

brifordwylie commented Apr 10, 2024 •

edited

Loading

BSd3v commented Apr 10, 2024 •

edited

Loading

brifordwylie commented Apr 10, 2024 •

edited

Loading

ndrezn Apr 16, 2024 •

edited

Loading

ndrezn Apr 16, 2024 •

edited

Loading