Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Selected rows fixes #283

Closed
wants to merge 22 commits into from
Closed

Selected rows fixes #283

Show file tree
Hide file tree
Changes from 16 commits
Commits
Show all changes
22 commits
Select commit Hold shift + click to select a range
caac0a3
adjustments to webpack to improve build speed
BSd3v Apr 4, 2024
c5d1723
Merge branch 'plotly:main' into webpack-adjustments
BSd3v Apr 4, 2024
2f4bb82
updating circleci browser-tools to match dash
BSd3v Apr 4, 2024
b6a32d7
updating to latest version of chrome
BSd3v Apr 4, 2024
3d4bdae
altering version of chrome
BSd3v Apr 4, 2024
148d326
adjusting verison of chrome
BSd3v Apr 4, 2024
dc90534
adjusting to install from the circleci instead of specific versions
BSd3v Apr 4, 2024
fabaf77
adding extra pytest install
BSd3v Apr 4, 2024
e276e01
updating image to 3.12.1 vs 3.9.9
BSd3v Apr 4, 2024
a76e43b
reverting to 3.9.9 and uninstall pytest to reinstall pytest with a lo…
BSd3v Apr 4, 2024
3cf29bd
fixing tyop
BSd3v Apr 4, 2024
7fb3913
fixing `selectedRows`
BSd3v Apr 9, 2024
f7ef79e
Update test_column_state.py
BSd3v Apr 9, 2024
f2c2052
adding test for adding `rowData` at the same time as `selectedRows`
BSd3v Apr 9, 2024
7acd81e
Merge branch 'selectedRows-fixes' of github.com:BSd3v/dash-ag-grid-re…
BSd3v Apr 9, 2024
6a917f3
adding test for `selectedRows` and the different ways for perform sel…
BSd3v Apr 16, 2024
434bd13
Merge pull request #281 from BSd3v/webpack-adjustments
ndrezn Apr 22, 2024
9be0cfe
fixing `selectedRows`
BSd3v Apr 9, 2024
a889ebc
adding test for adding `rowData` at the same time as `selectedRows`
BSd3v Apr 9, 2024
214ead8
Update test_column_state.py
BSd3v Apr 9, 2024
30d9d4c
adding test for `selectedRows` and the different ways for perform sel…
BSd3v Apr 16, 2024
e656dcf
Merge branch 'selectedRows-fixes' of github.com:BSd3v/dash-ag-grid-re…
BSd3v Apr 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions .circleci/config.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
version: 2.1

orbs:
browser-tools: circleci/browser-tools@1.4.4
browser-tools: circleci/browser-tools@1.4.8

jobs:
test: &test
Expand All @@ -12,9 +12,8 @@ jobs:
password: $DASH_PAT_DOCKERHUB
steps:
- checkout
- browser-tools/install-browser-tools:
chrome-version: 116.0.5845.96
firefox-version: 116.0.3
- browser-tools/install-chrome
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These diffs are all coming from #281 right? So we'll need to merge #281 first, rebase, then merge in these changes..?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes. That is correct.

- browser-tools/install-chromedriver
- run:
name: Install Python deps
command: |
Expand All @@ -36,6 +35,8 @@ jobs:
name: Run tests
command: |
. venv/bin/activate
pip uninstall -y pytest
pip install 'pytest<8.1.0'
Comment on lines +38 to +39
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why is there an uninstall step here? Also, why pin at <8.1.0?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pytest has an issue with something and was failing. Reverting back to a lower version solved the issue.

pytest --headless
test-react-18:
<<: *test
Expand Down
Loading