Merge pull request #2126 from AnnMarieW/pages-redirect-home

Adds ability to redirect "/" when using pages

CHANGELOG.md

@@ -8,6 +8,7 @@ This project adheres to [Semantic Versioning](https://semver.org/).
 - [#2109](https://github.com/plotly/dash/pull/2109) Add `maxHeight` to Dropdown options menu.
 
 ### Fixed
+- [#2126](https://github.com/plotly/dash/pull/2126) Fix bug where it was not possible to redirect from root when using pages.
 - [#2114](https://github.com/plotly/dash/pull/2114) Fix bug [#1978](https://github.com/plotly/dash/issues/1978) where text could not be copied from cells in tables with `cell_selectable=False`.
 - [#2102](https://github.com/plotly/dash/pull/2102) Fix bug as reported in [dash-labs #113](https://github.com/plotly/dash-labs/issues/113) where files starting with `.` were not excluded when building `dash.page_registry`.
 - [#2100](https://github.com/plotly/dash/pull/2100) Fixes bug where module name in for a custom `not_found_404` page is incorrect in the `dash.page_registry` when not using the `pages` folder.

dash/dash.py

@@ -556,7 +556,8 @@ def _handle_error(_):
         self._add_url("_dash-update-component", self.dispatch, ["POST"])
         self._add_url("_reload-hash", self.serve_reload_hash)
         self._add_url("_favicon.ico", self._serve_default_favicon)
-        self._add_url("", self.index)
+        if not self.use_pages:
+            self._add_url("", self.index)
 
         # catch-all for front-end routes, used by dcc.Location
         self._add_url("<path:path>", self.index)
@@ -2118,6 +2119,11 @@ def redirect():
                             fullname,
                             create_redirect_function(page["relative_path"]),
                         )
+            # set "/" if not redirected
+            try:
+                self._add_url("", self.index)
+            except AssertionError:
+                pass
 
     def run_server(self, *args, **kwargs):
         """`run_server` is a deprecated alias of `run` and may be removed in a

tests/integration/test_pages_redirect_home.py

@@ -0,0 +1,30 @@
+import dash
+
+
+def test_pare001_redirect_home(dash_duo):
+
+    app = dash.Dash(__name__, use_pages=True, pages_folder="")
+
+    dash.register_page(
+        "multi_layout1",
+        layout=dash.html.Div("text for multi_layout1", id="text_multi_layout1"),
+        path="/",
+    )
+
+    dash.register_page(
+        "redirect_home",
+        redirect_from=["/"],
+        layout=dash.html.Div("Redirect", id="redirect"),
+    )
+
+    app.layout = dash.page_container
+
+    dash_duo.start_server(app)
+
+    dash_duo.wait_for_page(url=f"http://localhost:{dash_duo.server.port}/redirect-home")
+    dash_duo.wait_for_text_to_equal("#redirect", "Redirect")
+
+    assert dash_duo.get_logs() == [], "browser console should contain no error"
+
+    # clean up after this test, so this redirect does not affect other pages tests
+    del dash.page_registry["redirect_home"]