Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds ability to redirect "/" when using pages #2126

Merged
merged 4 commits into from
Jul 12, 2022
Merged

Adds ability to redirect "/" when using pages #2126

merged 4 commits into from
Jul 12, 2022

Conversation

AnnMarieW
Copy link
Collaborator

@AnnMarieW AnnMarieW commented Jul 11, 2022 •
edited
Loading

This PR fixes the bug noted in the dash 2.5 announcement, where it's not possible to redirect from the root page "/"

Contributor Checklist

  • I have run the tests locally and they passed. (refer to testing section in contributing)
  • I have added tests, or extended existing tests, to cover any new features or bugs fixed in this PR

optionals

  • I have added entry in the CHANGELOG.md
  • If this PR needs a follow-up in dash docs, community thread, I have mentioned the relevant URLS as follows
    • here is the show and tell thread in Plotly Dash community

alexcjohnson
alexcjohnson approved these changes Jul 11, 2022
View reviewed changes
Copy link
Collaborator

@alexcjohnson alexcjohnson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent, nice fix! Add a changelog entry and I think it's ready. 💃

@alexcjohnson alexcjohnson merged commit a226108 into plotly:dev Jul 12, 2022
@AnnMarieW AnnMarieW mentioned this pull request Jul 25, 2022
Merged
@ned2 ned2 mentioned this pull request Jul 30, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexcjohnson alexcjohnson alexcjohnson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@AnnMarieW @alexcjohnson