Fix long_callback for slow responses and small polling intervals #2058
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes (#1769)
This avoids the race-condition between the long_callback interval triggers and the long callback returning slow/large payloads.
As mentioned in #1769 this PR basically does the following:
The code snippets for reseting the user store seem a little redundant between the
should_cancel
branch and the new parts of code. I'd be happy to refactor that somewhat, but wanted to keep the diff as small as possible for a start.Contributor Checklist
the testspytest -k long_callback
locally and they passed. (refer to testing section in contributing)optionals
CHANGELOG.md
Sebastian Eckweiler (sebastian.eckweiler@mercedes-benz.com), Mercedes-Benz AG on behalf of MBition GmbH (Imprint)