-
-
Notifications
You must be signed in to change notification settings - Fork 1.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mapbox-gl@1.0.0 + improvements #3987
Conversation
... navigation menu is now not included by default
- update no-access-token error msg - fixup click mocking action - fix relayouting cnt - add TODOs about new (and annoying) mapbox-gl warn msg - add info atlas-server logic and test
- that is if all mapbox subplots on graph do not use Mapbox styles, DO NOT error when mapbox access token isn't set - moreover, add helpful log when multiple distinct tokens are set in same layout
... to avoid console warning on subplot instantiation
staticPlot: gd._context.staticPlot | ||
}); | ||
|
||
mapbox = new Mapbox(gd, id); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice clean up here 👍
I am a bit surprised that the markers in the legend are now smaller in |
Thanks @etpinard for the very nice PR! I also noticed that 💃 |
- valid choropleth datum must have a valid location AND `z` value - set calcdata[i][j].index during calc so that choroplethmapbox can use it in its convert.js
... and update choropleth baselines that didn't show the "correct" default "black"
for geo AND mapbox base plot modules ... that way we do this only once when geo and mapbox modules are registered
- reusing choropleth calc, hover, select, eventData and feature2polygon - use `PlotlyGeoAssets` to stash fetched geojson url data - use two layers, one fill (to filled choropleth polygon), one line to draw `marker.line` styles - add mockAxis on mapbox subplot instances, used to format choroplethmapbox 'z' on hover
... similar to how we do things on geo subplots
- use _rehover wrapper similar to cartesian subplots and call it on moveend - split fx init code into prototype.initFx
- where by default chroroplethmapbox traces are placed above the top most "water" layer - N.B. we need to remove/add again layers when *below* is updated
Introducing densitymapbox traces
Add support for raster and image mapbox layers
Introducing choroplethmapbox traces
@plotly/plotly_js I'm looking for a final review. This PR now includes:
|
According to https://blog.mapbox.com/512-map-tiles-cb5bfd6e72ba, it looks they suggested using 512 resolution. |
How? I'm curious. |
I have rather limited experience on this. |
@archmoj so, I'm assuming you'd vote for having |
Yes in the case of |
... as showSkipped is now turned on by default on CI.
Upon further inspection, What do you think @archmoj ? |
This comment has been minimized.
This comment has been minimized.
Confirmed. Let's use 256. |
This is likely the first time ever that multiple |
This PR will serve as a base for all v1.49.0 mapbox-related improvements.
In brief, this PR:
v1.0.0
in 2d4fe9b (which went smooth apart from 5b43b8c) 🎉layout.mapbox.style
(e.g. from Open-Street Map, see mock in 23ffe4f). This resolves [Feature Request] use own style.json instead of mapbox access token #3592cc @plotly/plotly_js