Introducing choroplethmapbox traces #3988
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- valid choropleth datum must have a valid location AND `z` value - set calcdata[i][j].index during calc so that choroplethmapbox can use it in its convert.js
... and update choropleth baselines that
didn't show the "correct" default "black"
for geo AND mapbox base plot modules
... that way we do this only once when geo and mapbox modules
are registered
- reusing choropleth calc, hover, select, eventData and feature2polygon - use `PlotlyGeoAssets` to stash fetched geojson url data - use two layers, one fill (to filled choropleth polygon), one line to draw `marker.line` styles - add mockAxis on mapbox subplot instances, used to format choroplethmapbox 'z' on hover
... similar to how we do things on geo subplots
- use _rehover wrapper similar to cartesian subplots and call it on moveend - split fx init code into prototype.initFx
- where by default chroroplethmapbox traces are placed above the top most "water" layer - N.B. we need to remove/add again layers when *below* is updated
archmoj
reviewed
Jun 27, 2019
| moduleType: 'trace', | ||
| name: 'choroplethmapbox', | ||
| basePlotModule: require('../../plots/mapbox'), | ||
| categories: ['mapbox', 'gl', 'noOpacity'], |
There was a problem hiding this comment.
Later on the road, it may be of interest to have traces with opacity. Right?
There was a problem hiding this comment.
opacity here for choroplethmapbox traces would be equivalent to marker.opacity, so we don't need it.
There was a problem hiding this comment.
What about dimming marker.lines? Trace opacity may be handy for adjusting both.
There was a problem hiding this comment.
Maybe, but I'm not going to do this now for consistency with choropleth:
plotly.js/src/traces/choropleth/index.js
Line 26 in cb202a8
- move isNonBlankString in outer scope - add "" around URL in invalid-url error msg
... when marker.line.width===0
antoinerg
reviewed
Jun 28, 2019
Introducing densitymapbox traces
|
Is everyone subscribed to this PR ok with the behavior? |
|
No news, good news I guess. Merging this PR into #3987 to have all 1.49.0 mapbox items in one place |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Based off #3987
This PR adds a new mapbox-based trace type:
choroplethmapbox🎉 🗺️ 🛰️Example: https://codepen.io/etpinard/pen/orGQNe
In brief,
choroplethmapboxtraces have a very similar API as their geo-subplot cousinchoropleth. Both uselocationsandzto set the polygon-to-color mapping. But unlikechoropleth,choroplethmapboxtraces (currently) must be set with ageojsonattribute that contains polygon coordinates.Note that, this PR also fixes a
choroplethbug in 91e0319 - where we didn't use the correctmarker.line.colordefault.Things that work
geojsoncan be set either as URL string or{ }GeoJSON object. We accept GeoJSONs of typeFeatureandFeatureCollectionand geometries of typePolygonandMultiPolygon.choroplethchoroplethlogic, where the polygons' centroid is used.propertiesfields are accessible inhovertemplate(example)Things worthy of discussion
belowdefault.below(like inmapbox.layers) sets theidof the layer just below where thechoroplethmapboxtrace will be plotted. I tentatively chose the layer just above the last "water" layer. That is,choroplethmapboxtraces are plotted below roads and labels by default.below, we could plotchoroplethmapboxtraces above all background layers (but belowscattermapboxtraces) and have a defaultmarker.opacityof e.g. 0.7?Things that we could add
locationmode. The current behavior would correspond tolocationmode: 'geojson-id'. Some users might expect to identify GeoJSON features using theirproperties.name(this would correspond to e.g.locationmode: 'geojson-prop-name'. Moreover, we could also support thelocationmodevalues found in geo traces:'ISO-3', 'USA-states', 'country names'zkeyattribute as an alternative to thezarray. For example,zkey: 'value'would read off theproperties.valuevalues in the GeoJSON set bygeojsoncc @plotly/plotly_js @nicolaskruchten @chriddyp