-
-
Notifications
You must be signed in to change notification settings - Fork 2.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
PX: Avoid groupby
when possible and access groups more efficiently
#3765
Merged
Merged
Changes from 6 commits
Commits
Show all changes
15 commits
Select commit
Hold shift + click to select a range
9941749
short circuit more machinery when one_group
nicolaskruchten b97d197
more correct optimization
nicolaskruchten 6640d8f
:recycle: check for all same groups
jvdd 73b3c7c
:bug: make orders and sorted_group_names backwards compatible
jvdd dd2137b
Merge pull request #3767 from jvdd/one_group_short_circuit
nicolaskruchten 3ae0645
reorder computation to avoid an extra scan through the data
nicolaskruchten 067d4b0
optimize group access
nicolaskruchten 9498396
slicing seems ambitious
nicolaskruchten 35dbbe8
trying again with groups
nicolaskruchten cdae77c
possible fix
nicolaskruchten b3a4583
:broom: avoid unnecessary one_group groupby operations
jvdd 3043324
Merge pull request #3769 from jvdd/one_group_short_circuit
nicolaskruchten f97f2d2
Merge branch 'master' into one_group_short_circuit
nicolaskruchten f46f809
changelog
nicolaskruchten 4b22199
Merge branch 'master' into one_group_short_circuit
nicolaskruchten File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For the following snippet this line is executed twice for the exact same col ("variable");
I guess that the second computation could be avoided? (this is why I used
set(grouper)
to construct the order dictionary)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could memoize the results of this loop as a function of
col
, yeahThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(done)