Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jupyterlab 4 support #4217

Closed
wants to merge 3 commits into from
Closed

Jupyterlab 4 support #4217

wants to merge 3 commits into from

Conversation

alexcjohnson
Copy link
Collaborator

Fixes #4066 - Jupyterlab 4 changes its layout so the min-height CSS rule no longer works.
Unfortunately I've been unable to test this locally as something went wrong when I tried to install Jupyterlab 4... will try again next week but I'm pushing this up in case anyone else is interested to push it forward earlier.

  • I have added a CHANGELOG entry if fixing/changing/adding anything substantial.

@alexcjohnson
Copy link
Collaborator Author

Same test failure in the release_build workflow as in #4210, which also seems related to jlab4... still needs investigation which would sure be easier if I could get a working install locally 🙄

@alexcjohnson alexcjohnson mentioned this pull request Jun 2, 2023
1 task
@alexcjohnson
Copy link
Collaborator Author

Went with #4227 instead, which fixes the original issue but does nothing to update the build pipeline. We'll come back to that later when we're ready to update to the new packaging system.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Plotly figures are cropped in JupyterLab 4 (currently in preview)
1 participant