Jupyterlab v4 take2 #4227
Merged
Jupyterlab v4 take2 #4227
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 3, 2023
Closed
|
Hi, has this bugfix been integrated in a release? I encountered the same problem in 5.15.0. |
|
@WenjieZ yes this fix is part of 5.15.0. Jupyter is notorious for having multiple versions installed, you can confirm this is actually being rendered by 5.15 as it will have plotly.js v2.24.1 if you hover on the Plotly logo on a graph. (5.16 released last week has plotly.js v2.25.2) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Putting #4217 on hold for now since I still have not managed to update any local env I create to Jupyterlab 4 successfully, let's go a different route: take from #4217 the fix that I think will work for jupyterlab 4 3b4b324 and the little setup fix 411d66a, but pin our build process to jupyterlab 3 for now 8df887d. Turns out a full upgrade of the process to jupyterlab 4 entails also upgrading the build pipeline from Python 3.7 to 3.8 or later, so a bigger and riskier project than I want right now, and I can't find good information about whether the upgraded version of the extension will work with older versions of jupyterlab anyway.
Fortunately even for jupyterlab 3 users this change has a benefit: we previously set 360px as the minimum output height, but with this change that's just the default, if you set a smaller height that's what you'll get.